-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit metric exports #5675
Comments
Thanks for the details @jvalkeal,
We already account for this in the Please also see this section in the ref guide about this: https://docs.spring.io/spring-cloud-dataflow/docs/current/reference/htmlsingle/#_metrics_configuration_properties
Haha. Yep, I have been down this same road you are on w/ the Boot2/3 stuff.
If we remove it, what "hole" will that leave functionally? |
Folks from micrometer were open to do some further polish in |
Align wavefront version so that we don't have misaligned versions coming out from other parts of a metric system. Short story is that boot doesn't manage wavefront but there is an explicit dependency to wavefront sdk libs in metric system. Rename metric options within management for influx, prometheus and wavefront to align changes in boot itself. For rsocket proxy keep old management.metrics.export.prometheus.rsocket.enabled as that is going to get moved under micrometer spesific namespace when they release boot3 support. This commit was supposed to get skipper server to start but there is a new issue about missing bean org.springframework.statemachine.data.jpa.JpaStateMachineRepository which will need to get fixed in a separate commit. Fixes spring-cloud#5675
Align wavefront version so that we don't have misaligned versions coming out from other parts of a metric system. Short story is that boot doesn't manage wavefront but there is an explicit dependency to wavefront sdk libs in metric system. Rename metric options within management for influx, prometheus and wavefront to align changes in boot itself. For rsocket proxy keep old management.metrics.export.prometheus.rsocket.enabled as that is going to get moved under micrometer spesific namespace when they release boot3 support. This commit was supposed to get skipper server to start but there is a new issue about missing bean org.springframework.statemachine.data.jpa.JpaStateMachineRepository which will need to get fixed in a separate commit. Fixes spring-cloud#5675
Adding note here to remove the |
Adding note here to move back to the newer client rather than the simpleclient once this issue is complete: |
This is a short recap when going through various issues:
spring-cloud-dataflow-parent/pom.xml
manageswavefront-spring-boot-bom.version
as2.3.4
. Bit nasty as boot doesn't manage wavefront but depends something which then pulls specific wavefront sdk version. Should use3.2.0
and keep that aligned.influx
,prometheus
andwavefront
and export is disabled on default. Boot changed property format in spring-projects/spring-boot@be3523b, we need to change property names. In shortmanagement.metrics.export.prometheus.enabled
vs.management.prometheus.metrics.export.enabled
.micrometer-metrics/prometheus-rsocket-proxy
which still usesmanagement.metrics.export.prometheus.rsocket.enabled
, they never migrated to new property structure.prometheus-rsocket-proxy
claiming boot 3.x support so wondering if we should just remove this dependency.The text was updated successfully, but these errors were encountered: