Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client modules naming #7

Closed
arey opened this issue Nov 14, 2016 · 2 comments
Closed

Client modules naming #7

arey opened this issue Nov 14, 2016 · 2 comments
Labels
question

Comments

@arey
Copy link
Member

arey commented Nov 14, 2016

The names of those 2 maven modules are confused:

  • spring-petclinic-client => front-end
  • spring-petclinic-clients-service => Owner and Pet

We could rename the spring-petclinic-clients-service into spring-petclinic-customers-service (and the java package too). What do you think ?
@arey arey added the question label Nov 14, 2016
@mszarlinski
Copy link
Collaborator

Good point, I suggest spring-petclinic-ui and spring-petclinic-customers-service.

@arey
Copy link
Member Author

arey commented Nov 14, 2016

I like it.

@mszarlinski mszarlinski changed the title Client modules namming Client modules naming Nov 14, 2016
mszarlinski added a commit to mszarlinski/spring-petclinic-microservices that referenced this issue Nov 14, 2016
@mszarlinski
closes spring-petclinic#7 Client modules naming
751b02b
mszarlinski added a commit that referenced this issue Nov 17, 2016
@mszarlinski
Merge pull request #11 from mszarlinski/master
0c549dc 
closes #7 Client modules naming
arey pushed a commit to arey/spring-petclinic-microservices that referenced this issue Nov 29, 2016
@mszarlinski @arey
closes spring-petclinic#7 Client modules naming
2b80980
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Nov 29, 2016
@arey
spring-petclinic#7 Add logs to save method of the service layer
b90e1ed
arey added a commit to arey/spring-petclinic-microservices that referenced this issue Nov 29, 2016
@arey
spring-petclinic#7 Add spring-cloud-starter-sleuth dependency
1f75812
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arey @mszarlinski