Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON rendering setup to issue warning logs causes custom Page implementations not to render correctly #3137

Closed
odrotbohm opened this issue Aug 15, 2024 · 0 comments
Closed

JSON rendering setup to issue warning logs causes custom Page implementations not to render correctly #3137

odrotbohm opened this issue Aug 15, 2024 · 0 comments
Assignees
@odrotbohm
Labels
type: bug A general bug
Milestone
3.3.3 (2024.0.3)

Comments

@odrotbohm
Copy link
Member

It looks like we can switch to a BeanSerializerCustomizer to issue the log statement to avoid affecting the serializer detection.

References
@odrotbohm odrotbohm added the type: bug A general bug label Aug 15, 2024
@odrotbohm odrotbohm self-assigned this Aug 15, 2024
odrotbohm added a commit that referenced this issue Aug 15, 2024
@odrotbohm
Avoid affecting serialization of custom Page implementations in legac…
619ccd4 
…y mode.

Registering a StdConverter with Jackson to log a warning  about the Page serialization mode causes the target serializer to be only built for Page losing additional properties defined on extensions. We now instead register a no-op BeanSerializerModifier that issues the warning and doesn't affect the serializer selection.

Fixes GH-3137.
@odrotbohm odrotbohm added this to the 3.3.3 (2024.0.3) milestone Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@odrotbohm odrotbohm

Labels
type: bug A general bug
Projects
None yet
Milestone
3.3.3 (2024.0.3)
Development

No branches or pull requests
1 participant
@odrotbohm