Consider null value settings for types with custom conversion #4728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mp911de
reviewed
Jun 19, 2024
| return this; | ||
| } | ||
|
|
||
| return new DocumentAccessor(this.document) { |
There was a problem hiding this comment.
If we want to handle field write checks here, how about creating a named subclass that we would use across MappingMongoConverter in the write paths?
|
Hey guys, this PR looks like it would greatly fix the issue we'd have with the recent spring boot version. I was wondering, whether any update to this is planned? If support for this issue is desired, I'd love to help :) |
This commit fixes an issue where settings regarding storage of null values had been ignored if a custom converter took care of the conversion.
mp911de
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where settings regarding storage of
nullvalues had been ignored if a custom converter took care of the conversion.Let's do an initial round of review and check how dbrefs should be treated when there's this kind of conversion. Also, if we decide to go for it, we need to update the documentation.