-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DefaultRedisSerializationContextBuilder.string()
should assign param to stringTuple
instead of hashValueTuple
#2651
Milestone
Comments
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Jul 26, 2023
Closed
4 tasks
Hi @imzhoukunqiang - Yes, upon review, your assessment here seems correct. Thank you for catching this problem and contributing a fix, as well as the nice set of test cases. Much appreciated. It appears, this problem stems back to the I will finish the review, polish this a bit and merge it! |
jxblum
added
type: bug
A general bug
in: core
Issues in core support
and removed
status: waiting-for-triage
An issue we've not yet triaged
labels
Jul 27, 2023
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
pushed a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
…' to 'stringTuple'. Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'. Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
pushed a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
…ilder.string(). Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'. Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
pushed a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
…ilder.string(). Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'. Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
pushed a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
…ilder.string(). Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'. Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 27, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
pushed a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 28, 2023
…ilder.string(). Currently, the builder method incorrectly assigns 'tuple' SerializationPair<String> argument to 'hashValueTuple'. Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 28, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
jxblum
added a commit
to jxblum/spring-data-redis
that referenced
this issue
Jul 28, 2023
Closes spring-projects#2651 Original pull request: spring-projects#2652
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Team,
Below there is a code snippet from
DefaultRedisSerializationContext
,line 130. Thestring()
method assign paramtuple
tohashValueTuple
, it should be assignedstringTuple
I think.The text was updated successfully, but these errors were encountered: