Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edit ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees #2667

Closed
wants to merge 2 commits into from
Closed

Edit ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees #2667

wants to merge 2 commits into from

Conversation

jxblum
Copy link
Contributor

@jxblum jxblum commented Aug 8, 2023

See #2653

@jxblum jxblum requested a review from mp911de August 8, 2023 22:05
@jxblum jxblum added type: documentation A documentation update in: core Issues in core support in: lettuce Lettuce driver in: jedis Jedis driver labels Aug 8, 2023
@jxblum jxblum changed the title Edits to ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees. Edit ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees. Aug 8, 2023
@jxblum jxblum changed the title Edit ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees. Edit ref doc and Javadoc for connection classes to clearly state the Thread-safety guarantees Aug 8, 2023
mp911de pushed a commit that referenced this pull request Aug 10, 2023
@jxblum @mp911de
Edit ref docs and Javadoc for connection classes to clearly state the…
48b765d 
… Thread-safety guarantees.

Closes #2653
Original pull request: #2667
mp911de added a commit that referenced this pull request Aug 10, 2023
@mp911de
Polishing.
7d306ed 
Tweak wording around thread-safety. Include notices in connection factories.

Reformat asciidoc.

See #2653
Original pull request: #2667
mp911de pushed a commit that referenced this pull request Aug 10, 2023
@jxblum @mp911de
Edit ref docs and Javadoc for connection classes to clearly state the…
4bf1d06 
… Thread-safety guarantees.

Closes #2653
Original pull request: #2667
mp911de added a commit that referenced this pull request Aug 10, 2023
@mp911de
Polishing.
76da57e 
Tweak wording around thread-safety. Include notices in connection factories.

Reformat asciidoc.

See #2653
Original pull request: #2667
mp911de pushed a commit that referenced this pull request Aug 10, 2023
@jxblum @mp911de
Edit ref docs and Javadoc for connection classes to clearly state the…
91affcb 
… Thread-safety guarantees.

Closes #2653
Original pull request: #2667
mp911de added a commit that referenced this pull request Aug 10, 2023
@mp911de
Polishing.
05ae96f 
Tweak wording around thread-safety. Include notices in connection factories.

Reformat asciidoc.

See #2653
Original pull request: #2667
@mp911de mp911de added this to the 3.0.9 (2022.0.9) milestone Aug 10, 2023
@mp911de
Copy link
Member

mp911de commented Aug 10, 2023

That's merged and backported now.

@mp911de mp911de closed this Aug 10, 2023
@mp911de mp911de deleted the issue/2653 branch August 10, 2023 09:25
@mp911de mp911de linked an issue Aug 10, 2023 that may be closed by this pull request
Document that RedisConnection is not Thread-safe #2653
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de Awaiting requested review from mp911de

@christophstrobl christophstrobl Awaiting requested review from christophstrobl

Assignees
No one assigned
Labels
in: core Issues in core support in: jedis Jedis driver in: lettuce Lettuce driver type: documentation A documentation update
Projects
None yet
Milestone
3.0.9 (2022.0.9)
Development

Successfully merging this pull request may close these issues.

Document that RedisConnection is not Thread-safe
2 participants
@jxblum @mp911de