Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elimate Code Duplication in DefaultRedisList #2997

Closed
wants to merge 3 commits into from
Closed

Elimate Code Duplication in DefaultRedisList #2997

wants to merge 3 commits into from
+7 −19

Conversation

kjb512
Copy link

@kjb512 kjb512 commented Sep 14, 2024 •
edited
Loading

  • You have read the Spring Data contribution guidelines.
  • You use the code formatters provided here and have them applied to your changes. Don’t submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.
  • You added yourself as author in the headers of the classes you touched. Amend the date range in the Apache license header if needed. For new types, add the license header (copy from another file and set the current year only).

Closes #2996

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Sep 14, 2024
@kjb512 kjb512 marked this pull request as ready for review September 14, 2024 23:30
@mp911de mp911de self-assigned this Sep 16, 2024
@mp911de mp911de added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Sep 16, 2024
mp911de pushed a commit that referenced this pull request Sep 17, 2024
@mp911de
Remove duplicate code in DefaultRedisList.
5ff156c 
Closes: #2996
Original pull request: #2997
mp911de added a commit that referenced this pull request Sep 17, 2024
@mp911de
Polishing.
f687de9 
Add missing Nullable annotations. Reorder methods.

See: #2996
Original pull request: #2997
mp911de pushed a commit that referenced this pull request Sep 17, 2024
@mp911de
Remove duplicate code in DefaultRedisList.
5d7adf0 
Closes: #2996
Original pull request: #2997
mp911de added a commit that referenced this pull request Sep 17, 2024
@mp911de
Polishing.
c16b863 
Add missing Nullable annotations. Reorder methods.

See: #2996
Original pull request: #2997
mp911de pushed a commit that referenced this pull request Sep 17, 2024
@mp911de
Remove duplicate code in DefaultRedisList.
078f6ba 
Closes: #2996
Original pull request: #2997
mp911de added a commit that referenced this pull request Sep 17, 2024
@mp911de
Polishing.
7dd8b8e 
Add missing Nullable annotations. Reorder methods.

See: #2996
Original pull request: #2997
@mp911de
Copy link
Member

mp911de commented Sep 17, 2024

Thank you for your contribution. That's merged, polished, and backported now.

@mp911de mp911de closed this Sep 17, 2024
@mp911de mp911de added this to the 3.2.11 (2023.1.11) milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mp911de mp911de

Labels
type: task A general task
Projects
None yet
Milestone
3.2.11 (2023.1.11)
Development

Successfully merging this pull request may close these issues.

Elimate Code Duplication in DefaultRedisList
3 participants
@kjb512 @mp911de @spring-projects-issues