Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor StringBasedJdbcQuery to no longer require BeanFactory #1872

Closed
mp911de opened this issue Sep 4, 2024 · 2 comments
Closed

Refactor StringBasedJdbcQuery to no longer require BeanFactory #1872

mp911de opened this issue Sep 4, 2024 · 2 comments
Assignees
@schauder
Labels
type: enhancement A general enhancement
Milestone
3.4 RC1 (2024.1.0)

Comments

@mp911de
Copy link
Member

mp911de commented Sep 4, 2024

We already accept RowMapperFactory in StringBasedJdbcQuery that could serve as abstraction to not require BeanFactory. JdbcQueryLookupStrategy provides a RowMapperFactory implementation so that JdbcQueryLookupStrategy could serve as entry point for a RowMapperFactory implementation using BeanFactory. We can extend RowMapperFactory to resolve bean references and reduce so coupling in StringBasedJdbcQuery.
@mp911de mp911de added the type: task A general task label Sep 4, 2024
@schauder
Copy link
Contributor

schauder commented Sep 4, 2024

Not sure I understand how you envision this.

The BeanFactory is also used to obtain a ResultSetExtractor. Would you have the BeanFactory replaced by a ResultSetExtractor?

@mp911de
Copy link
Member Author

mp911de commented Sep 4, 2024

We ask BeanFactory to resolve references for ResultSetExtractor and RowMapper. I would like to extend RowMapperFactory to be able to do that so that we move the lookup into an implementation instead of passing BeanFactory around.

@schauder schauder self-assigned this Sep 6, 2024
schauder added a commit that referenced this issue Sep 6, 2024
@schauder
Polishing.
3ec43de 
Fix Javadoc.

See #1872
schauder added a commit that referenced this issue Sep 6, 2024
@schauder
StringBasedJdbcQuery no longer requires BeanFactory.
5513bbe 
The lookup is now performed by the `RowMapperFactory`.

Closes #1872
@schauder schauder mentioned this issue Sep 6, 2024
Closed
mp911de pushed a commit that referenced this issue Sep 16, 2024
@schauder @mp911de
Polishing.
9e91a0e 
Fix Javadoc.

See #1872
Original pull request: #1874
mp911de added a commit that referenced this issue Sep 16, 2024
@mp911de
Polishing.
033ac1f 
Refactor JdbcLookupStrategy to not generally require BeanFactory. Reintroduce deprecated setBeanFactory(…) method.

See #1872
Original pull request: #1874
@mp911de mp911de added type: enhancement A general enhancement and removed type: task A general task labels Sep 16, 2024
@mp911de mp911de added this to the 3.4 M2 (2024.1.0) milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schauder schauder

Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
3.4 RC1 (2024.1.0)
Development

Successfully merging a pull request may close this issue.

StringBasedJdbcQuery no longer requires BeanFactory spring-projects/spring-data-relational
2 participants
@schauder @mp911de