-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
maxAttemptsExpression is not evaluated when an exceptionExpression is set #383
Comments
您好,我已经收到您的邮件,将尽快给您回复。
|
Confirmed - however, it only applies if Lines 375 to 385 in fa00aa1
|
garyrussell
added a commit
to garyrussell/spring-retry
that referenced
this issue
Oct 2, 2023
Resolves spring-projects#383 If explicit exceptions are referenced, and an `exceptionExpression` is provided, the `maxAttemptsExpression` was ignored.
artembilan
pushed a commit
that referenced
this issue
Oct 2, 2023
Resolves #383 If explicit exceptions are referenced, and an `exceptionExpression` is provided, the `maxAttemptsExpression` was ignored.
snicoll
changed the title
maxAttemptsExpression is never evaluated if you pass in exceptionExpression !!
maxAttemptsExpression is not evaluated when an exceptionExpression is set
Oct 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@retryable doesnt seem to evaluate maxAttemptsExpression while creating the retryTemplate, if it has an exceptionExpression
This piece of code in AnnotationAwareRetryOperationsInterceptor.java should be modified i guess .
The maxAttempts supplies should be evaluated no matter , exceptionExpression is present or not.
This should be like this maybe
The text was updated successfully, but these errors were encountered: