Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct HttpSessionCsrfTokenRepository Documentation #15392

Merged
merged 2 commits into from
Jul 29, 2024
Merged

Correct HttpSessionCsrfTokenRepository Documentation #15392

merged 2 commits into from
Jul 29, 2024

Conversation

Junhyunny
Copy link
Contributor

I fixed the explanation about HttpSessionCsrfTokenRepository class. This class loads CRSF token from and save into a session.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jul 10, 2024
jzheaux
jzheaux requested changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Junhyunny! Please see my inline feedback.

Also, are you able to rebase the PR on 5.8.x so all the documentation gets this correction? If not, that's a step I can do for you.

docs/modules/ROOT/pages/servlet/exploits/csrf.adoc Outdated Show resolved Hide resolved
@jzheaux jzheaux self-assigned this Jul 22, 2024
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: bug A general bug and removed status: waiting-for-triage An issue we've not yet triaged labels Jul 22, 2024
@Junhyunny
Copy link
Contributor Author

Junhyunny commented Jul 25, 2024 •
edited
Loading

Thanks, @Junhyunny! Please see my inline feedback.

Also, are you able to rebase the PR on 5.8.x so all the documentation gets this correction? If not, that's a step I can do for you.

Do you mean make a new PR from 5.8.x. So you can easily merge into 6.2.x, 6.3.x and main finally? I feel rebasing this commit on 5.8.x difficult. There are conflicts and many commits for rebasing.

@jzheaux jzheaux changed the base branch from main to 6.2.x July 29, 2024 20:01
@jzheaux
Copy link
Contributor

jzheaux commented Jul 29, 2024

No problem, @Junhyunny, I'll take care of it!

It appears that the first instance of this bug is on 6.2.x, so I've rebased to that instead.

@jzheaux jzheaux changed the title Fix explanation for HttpSessionCsrfTokenRepository Correct HttpSessionCsrfTokenRepository Documentation Jul 29, 2024
@jzheaux jzheaux added this to the 6.2.6 milestone Jul 29, 2024
@jzheaux jzheaux merged commit e51507e into spring-projects:6.2.x Jul 29, 2024
4 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Jul 29, 2024

Thanks, @Junhyunny! This is now merged into 6.2.x, 6.3.x, and main.

@Junhyunny Junhyunny deleted the csrf-docs branch July 29, 2024 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: docs An issue in Documentation or samples type: bug A general bug
Projects
None yet
Milestone
6.2.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Junhyunny @jzheaux @spring-projects-issues