-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose finalPackages
#68
Changes from 3 commits
b820aef
c85013c
c93938e
e581f40
7729db0
a44c282
0f3e97b
7f4c35e
ab3e200
421b7f9
f14492f
c66cd64
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
#!/usr/bin/env sh | ||
|
||
# Renders the docs, prints the location of the docs, opens the docs if possible | ||
# | ||
# Does not run the link checker. That's done in runtest.sh. | ||
|
||
nix --option sandbox false \ | ||
build --override-input haskell-flake path:${FLAKE} \ | ||
-L --show-trace \ | ||
github:hercules-ci/flake.parts-website \ | ||
"$@" | ||
|
||
echo "Docs rendered to $PWD/result/options/haskell-flake.html" | ||
|
||
# Works on linux | ||
if type xdg-open &>/dev/null; then | ||
xdg-open result/options/haskell-flake.html | ||
fi |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,4 +15,10 @@ echo "\n||| Testing nix flake checks" | |
nix --option sandbox false \ | ||
build --override-input haskell-flake path:${FLAKE} -L .#check | ||
|
||
echo "\n||| Testing docs" | ||
nix --option sandbox false \ | ||
build --override-input haskell-flake path:${FLAKE} \ | ||
-L --show-trace \ | ||
github:hercules-ci/flake.parts-website#checks.x86_64-linux.linkcheck | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd remove There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The sandbox was disabled in an earlier command, so I assumed that you run this in a setup where that's necessary. This build works fine in the sandbox, but I've only ever built it in a nice NixOS-based sandbox. The verbosity is helpful when this runs in CI. You'll only look at it when it fails, and then you want all the info. Module system errors tend to need There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A proper CI solves this problem in the UI, but admittedly consuming an unpinned input like the site here isn't possible yet in Hercules. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Anyway, I've changed it so that logs only appear when there's a problem. Still not great if the builder hangs, but that's unlikely to be a problem here. |
||
|
||
echo "\n||| All tests passed!" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like
readonly
has no effect, because I can still setfinalPackages.foo = ./.;
(evenfinalPackages = ./.;
) intest/flake.nix
?Or does it just silently ignore user values?