Merge pull request #8 from butuzov/off-by-one

fix: off-by-one error
ssgreg · Sep 17, 2021 · 3d6ba68 · 3d6ba68
2 parents 0d1e458 + 73b34ed
commit 3d6ba68
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -48,3 +48,7 @@ func bar() int {
     return a
 }
 ```
+
+# Args
+
+* `-block-size n` size of the block (including return statement that is still "OK") so no return split required.
diff --git a/pkg/nlreturn/nlreturn.go b/pkg/nlreturn/nlreturn.go
@@ -50,11 +50,11 @@ func run(pass *analysis.Pass) (interface{}, error) {
 }
 
 func inspectBlock(pass *analysis.Pass, block []ast.Stmt) {
-
 	for i, stmt := range block {
 		switch stmt.(type) {
 		case *ast.BranchStmt, *ast.ReturnStmt:
-			if line(pass, stmt.Pos())-line(pass, block[0].Pos()) < blockSize {
+
+			if i == 0 || line(pass, stmt.Pos())-line(pass, block[0].Pos()) < blockSize {
 				return
 			}