Add .babelrc to .npmignore #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 4 4
Lines 129 129
=====================================
Hits 129 129Continue to review full report at Codecov.
|
|
Hi @randycoulman , I apologize for completely missing this PR. I can't believe it's sat here for 20 days! Let me do a little research and testing to make sure it's safe and then I'd be glad to merge. |
|
@randycoulman Please rebase this against master and I'll merge and publish. Thanks for the PR! |
randycoulman
force-pushed
the
npmignore-babelrc
branch
from
ca0a4b5
to
b13aaa6
Compare
|
@sslotsky Rebase is done. Thanks! |
|
@randycoulman It's been published in 1.2.5. |
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this package! It looks like it's going to be super-useful for us.
We're having a problem using it in a react-native project, however.
Based on our research, it looks like that in order to allow this package to work with react-native, it is necessary to exclude the
.babelrcfile from the npm package.This is an unfortunate limitation in the react-native packager, but at present it is the best-known solution to the problem.
See facebook/react-native#4062 for details.