added no-op statements to remove warnings #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
having those warning adds noise to gcc's output : Source for the method : https://stackoverflow.com/questions/1486904/how-do-i-best-silence-a-warning-about-unused-variables Removing those two : .pio/libdeps/debug/TeensyID/TeensyID.cpp:119:28: warning: unused parameter 'uid' [-Wunused-parameter] void kinetisUID(uint32_t *uid) { ^ .pio/libdeps/debug/TeensyID/TeensyID.cpp:163:27: warning: unused parameter 'uuid' [-Wunused-parameter] void teensyUUID(uint8_t *uuid) {
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey!
First, great lib ! very simple, useful and intuitive.
If I understand correctly these 2 methods are meant to be empty.
if so, having those warning adds noise to gcc's output with -Wall :
.pio/libdeps/debug/TeensyID/TeensyID.cpp:119:28: warning: unused parameter 'uid' [-Wunused-parameter]
void kinetisUID(uint32_t *uid) {
^
.....
.pio/libdeps/debug/TeensyID/TeensyID.cpp:163:27: warning: unused parameter 'uuid' [-Wunused-parameter]
void teensyUUID(uint8_t *uuid) {
.....
I made a patch that adds no assembly but suppresses undue warnings.
Source for the method : https://stackoverflow.com/questions/1486904/how-do-i-best-silence-a-warning-about-unused-variables