Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): use fedora:33 instead of fedora:latest #14

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Conversation

luk1337
Copy link
Contributor

@luk1337 luk1337 commented Apr 28, 2021

Apparently F34 became latest couple hours ago and
thus Darwin builds fail now.

@luk1337
Copy link
Contributor Author

luk1337 commented Apr 28, 2021

Kinda unlucky. You can merge once https://github.com/luk1337/payload-dumper-go/actions/runs/791045120 succeeds.

Apparently F34 became `latest` couple hours ago and
thus Darwin builds fail now.
@luk1337 luk1337 changed the title chore(ci): Use fedora:33 instead of fedora:latest chore(ci): use fedora:33 instead of fedora:latest Apr 28, 2021
@luk1337
Copy link
Contributor Author

luk1337 commented Apr 28, 2021

Looks like #13 fixed -dynamic linker flag issue but we'd need newer macos sdk since F34 has golang >1.14
But #13 + #14 works so you can go ahead and merge both changes and then retag 1.1.0.

@ssut ssut merged commit 9378850 into ssut:main Apr 28, 2021
@ssut
Copy link
Owner

ssut commented Apr 28, 2021

Nice work! Thank you.

@luk1337
Copy link
Contributor Author

luk1337 commented Apr 28, 2021

I'll look into fetching current macos sdk in separate job similarly to here — https://github.com/itamae-kitchen/mitamae/blob/master/.github/workflows/build.yml#L59-L74 later on. That should let us also build Darwin/ARM64 and upgrade to newer golang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants