Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix textureSize #60

Merged
merged 1 commit into from
Jul 9, 2024
Merged

fix textureSize #60

merged 1 commit into from
Jul 9, 2024

Conversation

bayazit
Copy link
Contributor

@bayazit bayazit commented Feb 19, 2024

No description provided.

@dy
Copy link
Member

dy commented Feb 19, 2024

Can you pls add some explainer / test?

@bayazit
Copy link
Contributor Author

bayazit commented Feb 19, 2024

Can you pls add some explainer / test?

There are two handlers for 'texture.type' on lines 760 and 769.
There is no handler for 'textureSize.type'.
It's mistake on the line 769.

@dy dy merged commit 7f6f2c6 into stackgl:master Jul 9, 2024
3 checks passed
@dy
Copy link
Member

dy commented Jul 9, 2024

Thanks @bayazit looks meaningful, hope I understand it right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bayazit @dy