nethermind: adding secret name override #556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @kaplanmaxe, thanks for the PR, please up chart version here: https://github.com/stakewise/helm-charts/blob/main/charts/nethermind/Chart.yaml#L5 |
|
done! |
antares-sw
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Big fan of this repo!
The current way secrets are handled in this repo is not the most ideal in my opinion. While the docs show an example of specifying the JWT token via an environment variable (which is not bad security wise), if one wanted to track their
values.yamlfile in git, the current chart requires.Values.global.JWTSecretto be tracked in code.Additionally, it's very common for people to use external secret providers like Hashicorp Vault (which I have seen Stakewise supports in some areas already). To do this, one could use a SecretProviderClass (or the vault injector obviously).
This PR allows for: