Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tbb_scheduler_init.h include from the test #1001

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

rok-cesnovar
Copy link
Member

Summary:

This include is throwing warnings in stan-dev/math#2447

The warnings looks like this:

stan/lib/stan_math/lib/tbb_2020.3/include/tbb/task_scheduler_init.h:21:154: note: #pragma message: TBB Warning: tbb/task_scheduler_init.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manual.
 #pragma message("TBB Warning: tbb/task_scheduler_init.h is deprecated. For details, please see Deprecated Features appendix in the TBB reference manual.")

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Rok Češnovar

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@stan-buildbot
Copy link
Contributor


Name Old Result New Result Ratio Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan 3.38 3.3 1.02 2.25% faster
low_dim_corr_gauss/low_dim_corr_gauss.stan 0.02 0.02 0.96 -3.93% slower
eight_schools/eight_schools.stan 0.11 0.12 0.96 -4.57% slower
gp_regr/gp_regr.stan 0.16 0.16 1.03 3.16% faster
irt_2pl/irt_2pl.stan 5.42 5.51 0.98 -1.53% slower
performance.compilation 91.19 89.05 1.02 2.35% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan 8.58 8.62 1.0 -0.48% slower
pkpd/one_comp_mm_elim_abs.stan 29.43 28.96 1.02 1.6% faster
sir/sir.stan 122.83 125.37 0.98 -2.06% slower
gp_regr/gen_gp_data.stan 0.04 0.04 1.05 4.46% faster
low_dim_gauss_mix/low_dim_gauss_mix.stan 3.22 3.21 1.0 0.26% faster
pkpd/sim_one_comp_mm_elim_abs.stan 0.38 0.37 1.03 3.18% faster
arK/arK.stan 1.99 2.0 1.0 -0.43% slower
arma/arma.stan 0.94 0.94 1.0 -0.06% slower
garch/garch.stan 0.51 0.51 0.99 -0.77% slower
Mean result: 1.00292889174

Jenkins Console Log
Blue Ocean
Commit hash: f4e5a9e


Machine information ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

@bbbales2
Copy link
Member

I don't know about the change here so I'll leave to @SteveBronder or @wds15.

@SteveBronder SteveBronder merged commit f1e5dbc into develop Mar 26, 2021
@rok-cesnovar rok-cesnovar deleted the remove_tbb_scheduler_init.h branch April 10, 2021 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants