rename probability functions

[bob-carpenter]

Summary:

Rename probability functions to match the language definitions.

Description:

• _log to _lpdf or _lpmf
• _log_cdf to _lcdf
• _log_ccdf to _lccdf

This will hugely simplify the code generation component of Stan.

To Do

• Rename functions
  • Update function name
  • Update documentation
  • Update file name
  • Update tests
• Figure out how to test distributions (might not need to change the generated code)
• Update makefile appropriately

Current Version:

v2.10.0

[syclik]

Do we need to worry about backwards compatibility here?

• normal_log() should be renamed to normal_lpdf()
• Do we need to keep a normal_log() function that's deprecated that calls normal_lpdf(); if so, how do we deal with deprecation?

[bob-carpenter]

We need to maintain backward compatibility until Stan 3.0. At that point, I can do the do-si-do in stan-dev/stan to get rid of the _log suffixes in the math lib and the language. For now, we should add a doxygen command for each of the _log forms: @deprecated ---how to replace it--- along with the @param etc. See: https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmddeprecated

[syclik]

Thanks. That makes sense.

On Fri, Oct 14, 2016 at 11:25 AM, Bob Carpenter notifications@github.com
wrote:

We need to maintain backward compatibility until Stan 3.0.
At that point, I can do the do-si-do in stan-dev/stan to get
rid of the _log suffixes in the math lib and the language.

For now, we should add a doxygen command for each of the _log
forms:

@deprecated ---how to replace it---

along with the @param etc. See:

https://www.stack.nl/~dimitri/doxygen/manual/commands.html#cmddeprecated

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#320 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZ_FyrPinL2zcxv5eAFTCfSbrSugIudks5qz58HgaJpZM4JTuYn
.