Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang tidy cleanup and using std algorithms #1373

Closed
wants to merge 17 commits into from
Closed

Clang tidy cleanup and using std algorithms #1373

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
b9f545b
Clang tidy with modernize-use-equals-default,readability-braces-aroun…
SteveBronder Sep 30, 2019
4064902
Adds range based for loops via clang tidy, accumulates in log_sum_exp…
SteveBronder Sep 30, 2019
23706ed
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/…
stan-buildbot Sep 30, 2019
bade075
include <numeric> in dot_self header
SteveBronder Sep 30, 2019
8a2dff8
Merge branch 'clang-tidy/braces-defaults_constructor-range_for_loops'…
SteveBronder Sep 30, 2019
2407b7a
copy-pasted an accumulate without changing the variable names from on…
SteveBronder Sep 30, 2019
8bb5458
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/…
stan-buildbot Sep 30, 2019
0c31b37
fix headers
SteveBronder Sep 30, 2019
d68129f
forgot accumulate is in numeric and not algorithm
SteveBronder Sep 30, 2019
f9275d1
test in scal was using unitialized vector?
SteveBronder Sep 30, 2019
06c465a
merge to develop
SteveBronder Oct 8, 2019
bdadd8e
cleanups for promote_elements
SteveBronder Oct 8, 2019
8656836
[Jenkins] auto-formatting by clang-format version 5.0.0-3~16.04.1 (ta…
stan-buildbot Oct 8, 2019
d716461
remove tbb stuff that should be ignored
SteveBronder Oct 8, 2019
3266349
Use auto in gp_exp_quad_cov, add rule of 5 to accumulator, and pass b…
SteveBronder Nov 3, 2019
90be53e
[Jenkins] auto-formatting by clang-format version 6.0.0 (tags/google/…
stan-buildbot Nov 3, 2019
c9fef6c
merge to develop
SteveBronder Nov 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
copy-pasted an accumulate without changing the variable names from on… 
…e file to another
  • Loading branch information
@SteveBronder
SteveBronder committed Sep 30, 2019
commit 2407b7a226722484f52f9653b306dc631007d83b
7 changes: 3 additions & 4 deletions stan/math/rev/arr/fun/sum.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,9 @@ class sum_v_vari : public vari {
size_t length_;

inline static double sum_of_val(const std::vector<var>& v) {
double result = std::accumulate(
x.begin(), x.end(), 0.0,
[](auto& acc, auto&& x_i) { return acc + x_i.val(); });
return result;
return std::accumulate(
v.begin(), v.end(), 0.0,
[](auto& acc, auto&& v_i) { return acc + v_i.val(); });
}

public:
Expand Down