-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run CI/CD only on Source Code #1724
Conversation
… in the Jenkinsfile do not have changes.
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really great, just a few details to hash out.
I played around with this in #1725 to confirm.
Switch to using `CHANGE_TARGET` environment variable instead of hardcoded develop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks great.
Just to confirm: would the upload doxygen step be skipped with this or not? I think we would like it to happen, right? |
It would not be skipped as that stage stayed the same. This wasnt tested because it only happens on develop. |
OK, thanks I couldn't figure it out looking at the patch or at the Jenkins logs. :) |
The upstream test have failed, hopefully it's unrelated. |
Its not related to this but the cmdstan PR for the same CI source code thing stan-dev/cmdstan#824 Something is different regarding tests on develop I guess. |
@serban-nicusor-toptal do we need the same fix as on cmdstan here? |
Yes and I found something else, I will update this PR after a fix on cmdstan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing the approval so this doesnt get merged accidentally
Jenkinsfile now reflects changes made on cmdstan after finding a bug.
Jenkins Console Log Machine informationProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010CPU: G++: Clang: |
This works great! One more minor left to do is to also skip the merge tests. It isnt a big deal but since we are already doing this. |
Should we skip |
No, doxygen changes should get pushed. |
Summary
Jenkins will now skip ci/cd pipeline if source code file paths defied in the Jenkinsfile do not have changes.
Checklist
Math issue [proposal] Stop using the wiki and make pages on the new site #1658
Copyright holder: (fill in copyright holder information)
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested