Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator+ for var matrices and matrix of vars #2115
operator+ for var matrices and matrix of vars #2115
Changes from 1 commit
4df2ba7
18a985c
16c77bb
e54858d
789a94d
b098c2c
1a42196
00ca894
c8c06e3
a062f9c
f67c251
efbf8b3
1f237d6
ee4f556
a7260da
3a368dd
759efe4
cd91e89
c2dcf5b
728de5a
8e138f0
bc0ca4e
0f1abb6
e9c32b4
fc47c80
90bd655
0814f7b
c5d5a88
c3cb134
0a43d5c
75b786c
c43241d
232e608
23d3d05
a70b3aa
a4674aa
a1ed9d5
8a55108
ee27ace
df959b6
b1f2982
e3bc35e
145a743
3464880
e793e6c
d0997e3
6ea6704
e4615df
b0b1440
1507a74
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think special handling of nans benefits either correctness of performance. The same propagation of nans happens in general branch as well. Maybe benchmark it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not related to this pull but I didn't realise we had this
require_var_vt
, that will simplify some of the wacky templating I've been resorting to. These require generics have been such a good addition!