allow glm functions to accept var matrix types #2655
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the glm functions and their tests to use
var<Matrix>
types. This also has a small bugfix for assigning row vectors tovar<Vector>
types. 99% of the PR here is actually just updating the glm tests to useTYPED_TESTS()
for checking both normal matrices and var matrices.Tests
The glm tests have all been modified to be a
TYPED_TEST_SUITE()
with each test usingTYPED_TEST()
instead of justTEST()
so that it will check if the functions work for bothEigen::Matrix<var>
andvar_value<Eigen::Matrix<double>>
types.Side Effects
Nope
Release notes
Have glm functions work for the new matrix type
Checklist
Math issue How to add static matrix? #1805
Copyright holder: Steve Bronder
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested