Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust signatures of eigenvalues and eigenvectors to accept expressions #2728

Merged
merged 2 commits into from
May 7, 2022

Conversation

WardBrian
Copy link
Member

Summary

This adjusts the signatures of the eigenvalues and eigenvectors functions to accept eigen expressions as input. This will allow them to be exposed in the Stan language: stan-dev/stanc3#1192

Tests

Existing tests for functionality remain in place. Additional expression tests will be automatically run when exposed in the compiler, I've run them locally for now.

Side Effects

None

Release notes

Updated the signatures of eigenvalues and eigenvectors to use our pseudo-concept require templates.

Checklist

  • Math issue #(issue number)

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine as is. My comments were more questions/optional and about style, not content.

stan/math/prim/fun/eigenvalues.hpp Show resolved Hide resolved
test/statement_types.py Show resolved Hide resolved
@rok-cesnovar rok-cesnovar merged commit fa08952 into develop May 7, 2022
@rok-cesnovar rok-cesnovar deleted the eigenvalues-vectors-expressions branch May 7, 2022 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants