Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Place template guards on prim/core operator overloads #2753

Merged
merged 2 commits into from
Jun 14, 2022

Conversation

WardBrian
Copy link
Member

Summary

We overload the basic operators (*, /, -, +) in math/prim/core, but we don't have any specific requirements on what the types are. This leads to issues like those noted in #2699 with signatures like subtract(complex, complex_matrix) => complex_matrix, and I believe it is also the source of some of the other template failures.

Tests

Existing tests are maintained, I've also tested that this allows subtract(complex, complex_matrix) => complex_matrix and add(complex, complex_matrix) => complex_matrix, which will be added to the expression tests following this.

Side Effects

I do not believe so. Any place where these overloads were being used and a Stan scalar was not the internal type was most likely incorrect beforehand.

Release notes

Checklist

  • Math issue: Related to Complex support for more linear algebra functions #2699

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member Author

This PR also fixes expression tests for the complex signatures of:

singular_values
svd_V
svd_U
elt_divide
eigenvalues_sym
eigenvectors_sym

It appears all of these were broken due to picking up incorrect overloads for operators from these files.

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean and simple. Thanks!

@WardBrian WardBrian merged commit 295f776 into develop Jun 14, 2022
@WardBrian WardBrian deleted the fix/guard-operator-overloads branch June 14, 2022 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants