Place template guards on prim/core operator overloads #2753
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We overload the basic operators (
*
,/
,-
,+
) inmath/prim/core
, but we don't have any specific requirements on what the types are. This leads to issues like those noted in #2699 with signatures likesubtract(complex, complex_matrix) => complex_matrix
, and I believe it is also the source of some of the other template failures.Tests
Existing tests are maintained, I've also tested that this allows
subtract(complex, complex_matrix) => complex_matrix
andadd(complex, complex_matrix) => complex_matrix
, which will be added to the expression tests following this.Side Effects
I do not believe so. Any place where these overloads were being used and a Stan scalar was not the internal type was most likely incorrect beforehand.
Release notes
Checklist
Math issue: Related to Complex support for more linear algebra functions #2699
Copyright holder: Simons Foundation
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested