Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guards to promote_scalar to allow similar tuples #2786

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

WardBrian
Copy link
Member

Summary

Follow on from #2701. The existing code has an ambiguous template overload when the tuple being promoted is only slightly different from the existing tuple

Tests

This adds a test for promoting tuple<scalar, scalar> to tuple<complex<scalar>, scalar> for double, var, fvar.

Side Effects

Release notes

Checklist

  • Math issue #(issue number)

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian WardBrian added this to In progress in Tuples via automation Jul 8, 2022
Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@WardBrian WardBrian merged commit ecfe6cb into develop Jul 9, 2022
Tuples automation moved this from In progress to Done Jul 9, 2022
@WardBrian WardBrian deleted the fix/promote-scalar-tuple-guard branch July 9, 2022 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Tuples
  
Done
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants