Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vectorize conj #2817

Merged
merged 6 commits into from
Sep 29, 2022
Merged

Vectorize conj #2817

merged 6 commits into from
Sep 29, 2022

Conversation

WardBrian
Copy link
Member

Summary

This vectorizes the conj function.

Tests

This did a minor re-write of the vectorization test framework to add the option for functions which only support complex inputs.
This changed the enum we use for settings accordingly:

-enum class PromoteToComplex { No, Yes };
+enum class ScalarSupport { Real, RealAndComplex, ComplexOnly };

Side Effects

Many test files changed as part of that renaming, but none of them changed in meaning.

Release notes

The conj function is vectorized for Eigen and std::vector types.

Checklist

  • Math issue: Closes Vectorize complex conjugate operation #2815

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

@WardBrian
Copy link
Member Author

After a bunch of CI issues this is finally passing and ready for review

Copy link
Collaborator

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WardBrian WardBrian merged commit cd60e75 into develop Sep 29, 2022
@WardBrian WardBrian deleted the feature/2815-vectorize-conj branch September 29, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vectorize complex conjugate operation
3 participants