Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow stan::math::minus on std::vectors #2840

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Conversation

WardBrian
Copy link
Member

Summary

This applies the vectorization framework to stan::math::minus to allow it to be applied to std::vectors and other containers.

Tests

Existing tests are updated to test vectorization, and a test is added to ensure the return type of std::vector<int> is std::vector<int>

Side Effects

None

Release notes

stan::math::minus can now accept std::vectors.

Checklist

  • Math issue : Feature request: make unary negation vectorized stanc3#529

  • Copyright holder: Simons Foundation

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Collaborator

@andrjohns andrjohns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @WardBrian

@WardBrian WardBrian merged commit f4c6817 into develop Nov 2, 2022
@WardBrian WardBrian deleted the feature/vectorize-minus branch November 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants