-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly test for empty distribution test changelist #2869
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks
@serban-nicusor-toptal this still didn't work - is there a good way to print a Groovy variable for debugging? For some reason I guess the list isn't empty but also doesn't contain a test, so I'm worried the value is like |
1d8e47c
Okay, I think I figured it out. Using |
|
Follow on to #2864 after test failures in #2846. It seems that the list of changes being empty still tried to run some tests (I assumed the
for
loop would just never execute) so this is making that conditional explicit.