Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inv_wishart_cholesky_test: make type of NaN argument double #2920

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

WardBrian
Copy link
Member

Summary

The inverse-Wishart (cholesky parameterization) tests currently have a test which tries the dof argument with NaN, but cast to an unsigned int. This is, I believe, a simple typo, and it causes the tests to fail when compiled with clang 16.0.6 (see stan-dev/ci-scripts#27)

Tests

Side Effects

None. The same test does not exist for the non-Cholesky version of the function.

Release notes

Fixed a type issue in the tests for inv_wishart_cholesky.

Checklist

  • Math issue #(issue number)

  • Copyright holder: (fill in copyright holder information)

    The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
    - Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
    - Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

  • the basic tests are passing

    • unit tests pass (to run, use: ./runTests.py test/unit)
    • header checks pass, (make test-headers)
    • dependencies checks pass, (make test-math-dependencies)
    • docs build, (make doxygen)
    • code passes the built in C++ standards checks (make cpplint)
  • the code is written in idiomatic C++ and changes are documented in the doxygen

  • the new changes are tested

Copy link
Member

@rok-cesnovar rok-cesnovar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪🏻

@andrjohns andrjohns merged commit 2e87eca into develop Jul 7, 2023
8 checks passed
@WardBrian WardBrian deleted the fix/inv_wishart_chol_test_type branch November 29, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants