Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #300. Adds PYTHON2 variable for use in cpplint #301

Merged
merged 1 commit into from
Jun 13, 2016

Conversation

syclik
Copy link
Member

@syclik syclik commented Jun 12, 2016

Submisison Checklist

  • Run unit tests: ./runTests.py test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary:

Adds a PYTHON2 make variable to control cpplint behavior.

How to Verify:

Run make cpplint PYTHON2=<some other python version>

Side Effects:

Removing the RUN_CPPLINT make variable.

Documentation:

Updated in the top level make help.

Reviewer Suggestions:

Anyone.

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University.

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@syclik syclik merged commit 0e67af6 into develop Jun 13, 2016
@syclik syclik deleted the feature/issue-300-python2-make branch June 13, 2016 19:03
@syclik syclik modified the milestones: Known Issues, v2.10.0 Jun 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant