-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set build and clean rules for SUNDIALS if external libs are used #3054
Conversation
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It still bothers me that we have different names for this than TBB (which uses only TBB_INC
and TBB_LIB
)
Yeah, agreed |
Summary
When using an external SUNDIALS library via the
SUNDIALS_TARGETS
variable added in #2861, Stan will still try to delete the library files when callingmake clean-all
.With
make/local
:Gives
clean-all
behaviour:This PR simply wraps the SUNDIALS build and clean rules in an
ifndef
, so that they are ignored whenSUNDIALS_TARGETS
is specifiedTests
N/A
Side Effects
N/A
Release notes
Fixed
clean-all
error when using external SUNDIALS librariesChecklist
Copyright holder: Andrew Johnson
The copyright holder is typically you or your assignee, such as a university or company. By submitting this pull request, the copyright holder is agreeing to the license the submitted work under the following licenses:
- Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
- Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)
the basic tests are passing
./runTests.py test/unit
)make test-headers
)make test-math-dependencies
)make doxygen
)make cpplint
)the code is written in idiomatic C++ and changes are documented in the doxygen
the new changes are tested