-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Allow Hessian functors to return Hessian as compressed sparse matrix" #3064
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Especially with the release next week it seems safer to revert if there are remaining questions
Jenkins Console Log Machine informationNo LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 20.04.3 LTS Release: 20.04 Codename: focalCPU: G++: Clang: |
Ah good to know, good catch! |
Reverts #3055
@andrjohns thinking about this the sparse matrix is only going to save more memory if nnz < (n * (n - 1) - 1) / 2. But we have a lower triangular which takes up n * (n-1) / 2 entries. So idt this is actually saving any memory