Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master to Release/v4.9.0 #3081

Merged
merged 716 commits into from
Jun 5, 2024
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
716 commits
Select commit Hold shift + click to select a range
ad52a3f
Change return type of linspaced_array
WardBrian Feb 6, 2024
854f6af
Update linspaced_array_test to actually test doubles
WardBrian Feb 6, 2024
9311228
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 6, 2024
41bc0e8
Fix copy/paste error in tests
WardBrian Feb 6, 2024
c6254fb
Merge pull request #3023 from stan-dev/fix/3022-linspaced-array
WardBrian Feb 7, 2024
69c62ed
Add failing test
WardBrian Feb 14, 2024
fa279ac
Make max(a,b) return auto
WardBrian Feb 14, 2024
35b094a
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 14, 2024
e5c966a
Same fix for min(int, int)
WardBrian Feb 14, 2024
413ff2f
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 14, 2024
cea2d39
Minor tidying for log_sum_exp helper function
andrjohns Feb 15, 2024
1cf8c04
Merge branch 'develop' into fix/constexpr-constants
andrjohns Feb 15, 2024
952ea3a
const char* updates
andrjohns Feb 15, 2024
2f9262e
Merge branch 'develop' into hyper-1f0
andrjohns Feb 15, 2024
f365972
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 15, 2024
e318d93
Merge branch 'develop' into grad_pfq-2
andrjohns Feb 15, 2024
a8f8062
Merge remote-tracking branch 'origin/develop' into feature/simplex_ro…
SteveBronder Feb 15, 2024
cad36a4
update docs
SteveBronder Feb 15, 2024
4575e4b
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 15, 2024
4cc95d4
uncomment include
Franzi2114 Feb 15, 2024
9d7f821
header tests
Franzi2114 Feb 15, 2024
fdda1d5
Merge commit 'c6254fbd45662b94189fff04f58f3b2f748da428' into HEAD
yashikno Feb 15, 2024
57e272b
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 15, 2024
6794454
!N to N==0
Franzi2114 Feb 16, 2024
899652e
docu
Franzi2114 Feb 16, 2024
5904b52
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 16, 2024
e9987b6
Temporarily disable problematic test
andrjohns Feb 16, 2024
8558ce8
Merge pull request #3024 from stan-dev/fix/max-scalar-return-type
WardBrian Feb 16, 2024
44dd969
Revert use of Boost's constants for LOG_PI
andrjohns Feb 16, 2024
c12fff9
Merge pull request #2830 from stan-dev/fix/constexpr-constants
andrjohns Feb 19, 2024
ff03a92
Merge remote-tracking branch 'origin/develop' into HEAD
SteveBronder Feb 20, 2024
c149fda
Avoid unneeded computation
andrjohns Feb 21, 2024
5f7c7b2
Merge branch 'develop' into grad_pfq-2
andrjohns Feb 21, 2024
2869827
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 21, 2024
d10a379
updating shebang in python testing scripts to allow for direct execution
syclik Jan 18, 2024
c6ebb2f
correct makefile documentation (within the makefile). We no longer ne…
syclik Jan 18, 2024
ac8a645
updating shebang in python testing scripts to allow for direct execution
syclik Jan 18, 2024
af48cb6
updating shebang in more python scripts
syclik Jan 18, 2024
37d7799
adding checks for cholesky factors; we found problems with user-facin…
syclik Jan 13, 2024
8cd890f
Update wishart_cholesky_rng_test.cpp
spinkney Jan 17, 2024
44920e1
updating test; test was incorrect. It passed in a non-cholesky factor…
syclik Jan 17, 2024
9024040
passing expression tests
syclik Jan 19, 2024
232fd33
passing expression tests
syclik Jan 20, 2024
1f8f3be
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jan 20, 2024
436b48e
release/v4.8.1: updating version numbers
Jan 23, 2024
8de3538
upgrading to boost v1.84.0; removing old boost library
andrjohns Jan 11, 2024
a123652
upgrading to boost v1.84.0; modifying with new version number
andrjohns Jan 11, 2024
07aed11
upgrading to boost v1.84.0; adding unmodified boost library
andrjohns Jan 11, 2024
62fb5de
upgrading to boost v1.84.0; pruning files
andrjohns Jan 11, 2024
f33fd3c
ibeta throw behaviour changed
andrjohns Jan 11, 2024
7ad7377
inv_inc_beta throw behaviour changed
andrjohns Jan 12, 2024
e4f5889
Fix exception in inv_wishart_cholesky test
WardBrian Jan 25, 2024
c1c2960
Re-add missing checks, revert test changes from #3007
WardBrian Jan 26, 2024
16bd832
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jan 26, 2024
af90916
Ensure pointer is 8-byte aligned in stack_alloc::alloc
WardBrian Jan 26, 2024
2576d9e
Update stack_alloc_test
WardBrian Jan 26, 2024
5a534bf
Update doc
WardBrian Jan 26, 2024
9fe464c
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Jan 26, 2024
6741f9d
CVODES exceptions converted to domain_error
WardBrian Jan 25, 2024
8939593
Change test
WardBrian Jan 26, 2024
4140057
Use bessel identity to improve grad calc
andrjohns Jan 20, 2024
9aa7975
Update von mises test to use AD framework
andrjohns Jan 20, 2024
4c7c9f8
Patch TBB makefile, add testing workflow
andrjohns Jan 8, 2024
8c6fe65
Remove interim testing workflow
andrjohns Jan 8, 2024
1805449
Document changes
andrjohns Jan 8, 2024
80841b1
Remove additional stray usage
andrjohns Jan 8, 2024
fbc8f84
Move shell setting to makefile
andrjohns Jan 9, 2024
34fc8dd
Using rtools check
andrjohns Jan 9, 2024
1bbec87
mingw32-make compatible override
andrjohns Jan 9, 2024
986c8d8
Update notes
andrjohns Jan 9, 2024
e881b01
Alt sh check
andrjohns Jan 9, 2024
ca70c6e
Remove new unused boost libs, add to boost update script
WardBrian Jan 31, 2024
7a77bcf
Silence unused variable warning in Boost
WardBrian Jan 31, 2024
cba756e
Ensure workdir is clean after step, cat make/local before running run…
Feb 2, 2024
1fa5eb5
Change return type of linspaced_array
WardBrian Feb 6, 2024
9b19654
Update linspaced_array_test to actually test doubles
WardBrian Feb 6, 2024
93cc98e
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 6, 2024
facb259
Fix copy/paste error in tests
WardBrian Feb 6, 2024
1800520
adding doc from @SteveBronder in the PR comments (with code formatting)
syclik Feb 10, 2024
7efb6ae
updating require_meta.md doc
syclik Feb 23, 2024
ca66d39
Merge branch 'develop' into feature/simplify-meta
syclik Feb 23, 2024
a8bb63e
adding code doc from @SteveBronder in the PR comments
syclik Feb 24, 2024
7f9e657
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 24, 2024
b97f02a
Tidying
andrjohns Feb 24, 2024
af23ee6
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 24, 2024
30273c8
Update handling integers
andrjohns Feb 26, 2024
b631517
Optimise handling of negative args
andrjohns Feb 26, 2024
a35dc3d
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 26, 2024
83edc29
New impl more accurate than 3F2
andrjohns Feb 26, 2024
8da99c5
Revert bool camel case
andrjohns Feb 27, 2024
1f1ff16
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 27, 2024
e53b697
Update stan/math/prim/fun/hypergeometric_1F0.hpp
andrjohns Feb 27, 2024
8e88783
Template typo
andrjohns Feb 27, 2024
69ce83b
Merge remote-tracking branch 'origin/develop' into feature/simplex_ro…
SteveBronder Feb 27, 2024
845d4e5
update for review comments
SteveBronder Feb 27, 2024
7b0c6be
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 27, 2024
406ee92
Align perfReport plugin after removing deprecated args
Feb 27, 2024
b6a227c
Align perfReport plugin after removing deprecated args
Feb 27, 2024
c2e938d
Adds simplex matrix free functions along with tests
SteveBronder Feb 27, 2024
e42fe2f
Merge commit 'b6a227ce58c41b5c2a956e793f86b3e59b43eaf1' into HEAD
yashikno Feb 27, 2024
dbe4416
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 27, 2024
b64b595
Add 'override' to built-in make variables
WardBrian Feb 27, 2024
f72a360
Merge pull request #3028 from stan-dev/always-use-our-flags
WardBrian Feb 28, 2024
52b36e6
Merge branch 'develop' into multi-normal-derivatives-2
spinkney Feb 28, 2024
3979ff5
remove obsolete includes
Franzi2114 Feb 28, 2024
b4353c4
update docs
Franzi2114 Feb 28, 2024
8919824
Trigger CI
andrjohns Feb 28, 2024
6e27745
Trigger CI
andrjohns Feb 28, 2024
c5e8f08
Merge pull request #2980 from stan-dev/multi-normal-derivatives-2
SteveBronder Feb 29, 2024
d37345c
Merge remote-tracking branch 'origin/develop' into fix/sparse-vari-impl
SteveBronder Feb 29, 2024
0656caa
update docs
SteveBronder Feb 29, 2024
d819287
update naming to be row and column stochastic matrices
SteveBronder Feb 29, 2024
a736fac
Merge commit 'c5e8f0844433af4d64ea8ac2086bdacd5e213477' into HEAD
yashikno Feb 29, 2024
df5e1d1
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Feb 29, 2024
bb12079
Jenkinsfile from develop branch
Franzi2114 Mar 1, 2024
2d5d4f7
Revert stray Jenkinsfile changes
andrjohns Mar 7, 2024
b21e184
Merge pull request #2822 from Franzi2114/feature/issue-2682-Add-7-par…
Franzi2114 Mar 13, 2024
6fd89cb
Remove unused lambda in hcubature.hpp
WardBrian Mar 19, 2024
dce1482
Remove unused variable in wiener5_lpdf.hpp
WardBrian Mar 19, 2024
630464c
Merge pull request #3030 from stan-dev/fix/hcubature-unused-warning
andrjohns Mar 19, 2024
0fcd7c9
Remove extra token in von_mises_text.hpp
WardBrian Mar 20, 2024
4498a87
Merge branch 'develop' into feature/simplify-meta
syclik Mar 20, 2024
33b9a82
Merge pull request #3032 from stan-dev/fix/extra-token-von-mises-test
andrjohns Mar 21, 2024
294f312
skip sqrt(x) gradient when x=0 for consistency with pow(x,y)
nhuurre Mar 21, 2024
7272c82
Apply style suggestions from code review
andrjohns Mar 21, 2024
e8ab249
Merge pull request #3033 from nhuurre/sqrt-0-gradient
andrjohns Mar 22, 2024
787256c
fixes #3035 by using log_modified_bessel to improve stability
venpopov Mar 23, 2024
76dea25
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 23, 2024
1d0ce81
Merge pull request #3036 from venpopov/feature/issue-3035-von_mises_s…
andrjohns Mar 23, 2024
f9b2212
Merge branch 'develop' into multi-student-t-derivatives
andrjohns Mar 23, 2024
4873b73
Merge commit '1d0ce81441c023bbc3091cc4c90c2166f30fcba6' into HEAD
yashikno Mar 23, 2024
6dbf9c3
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 23, 2024
d8d203d
Review requests
andrjohns Mar 23, 2024
d8d6196
Unused typedefs
andrjohns Mar 23, 2024
8f0731a
Merge pull request #2992 from stan-dev/feature/simplex_row_and_col
andrjohns Mar 23, 2024
b010193
Merge pull request #2990 from stan-dev/multi-student-t-derivatives
andrjohns Mar 23, 2024
cc417ed
updating doxygen documentation about require traits
syclik Mar 24, 2024
cf4fd5e
Merge branch 'develop' into feature/simplify-meta
syclik Mar 24, 2024
7831559
adding require_eigen_matrix_base_t
syclik Mar 24, 2024
8efc7cf
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 24, 2024
62ff9ae
adding require_not_assignable
syclik Mar 24, 2024
aaea3d8
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 24, 2024
ae6ca1f
Numerically stable weibull_cdf
andrjohns Mar 24, 2024
54257d9
Add y=0 handling, mix tests
andrjohns Mar 24, 2024
e87b32e
Update lcdf and vectorise mix tests
andrjohns Mar 24, 2024
5cef0e8
Unused typedef
andrjohns Mar 24, 2024
1c0f6be
Update comments
andrjohns Mar 24, 2024
ffdc348
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 24, 2024
7635348
Merge remote-tracking branch 'origin/develop' into fix/sparse-vari-impl
SteveBronder Mar 26, 2024
f627b37
Re-use computation
andrjohns Mar 26, 2024
dfd3949
cleanup docs, add innerNonZero() calls, speedup inplace ops for spars…
SteveBronder Mar 26, 2024
11e414e
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Mar 26, 2024
87d04dc
Merge pull request #3037 from stan-dev/robust-weibull-cdf
andrjohns Mar 26, 2024
35d6d53
Merge pull request #2971 from stan-dev/fix/sparse-vari-impl
andrjohns Mar 27, 2024
182cc29
Update doxygen/contributor_help_pages/require_meta.md
syclik Apr 2, 2024
0f77d06
Apply suggestions from code review
syclik Apr 2, 2024
a1d05d9
fixing meta doc
syclik Apr 2, 2024
b9309e7
updating doc
syclik Apr 2, 2024
1f94ed3
Merge pull request #2962 from stan-dev/hyper-1f0
syclik Apr 2, 2024
815a6c9
First pass vectorise
andrjohns Apr 11, 2024
689103a
Simplified mapping
andrjohns Apr 11, 2024
95bb31e
Move more to log scale
andrjohns Apr 11, 2024
72928c7
Fully stable log-scale
andrjohns Apr 11, 2024
76ef6a7
Begin centralising with std_normal_log_qf
andrjohns Apr 11, 2024
d8804d1
Update log-scale handling
andrjohns Apr 11, 2024
d51289a
Merge commit '1f94ed312376f726feb820bea90ed8df27974c17' into HEAD
yashikno Apr 11, 2024
7accce6
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 11, 2024
ecc713b
Apply review suggestions
andrjohns Apr 12, 2024
2d1cb20
Update doxygen/contributor_help_pages/require_meta.md
syclik Apr 12, 2024
a2a19dc
Update doxygen/contributor_help_pages/require_meta.md
syclik Apr 12, 2024
dd75ad7
updating doc with edits from Steve Bronder
syclik Apr 12, 2024
66b92b5
updating doc
syclik Apr 12, 2024
8b96c45
fixes aos csr matrix bug, still debugging soa matrix bug
Apr 12, 2024
de0c1a7
Merge pull request #2961 from stan-dev/grad_pfq-2
syclik Apr 13, 2024
b9d0a33
Merge pull request #2965 from stan-dev/feature/simplify-meta
syclik Apr 13, 2024
0a168c3
Merge remote-tracking branch 'origin/develop' into fix/csr-matrix-tim…
SteveBronder Apr 15, 2024
fec3689
update csr matrix multiply to avoid linker error for windows. Adds to…
SteveBronder Apr 15, 2024
6b8ae15
small fixes
SteveBronder Apr 15, 2024
c83cbfc
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 15, 2024
f594b2c
fix header error
SteveBronder Apr 15, 2024
d1feb19
use static_cast for bool conversion in sparse matrix loops
SteveBronder Apr 15, 2024
33f0825
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 15, 2024
7fa767d
Fix wording of error on dimension mismatch
WardBrian Apr 17, 2024
942ca76
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 17, 2024
11663a2
Merge pull request #3049 from stan-dev/fix/odd-matching-dims-error-wo…
andrjohns Apr 18, 2024
5c5dfc6
update csr_matrix_times_vector w adjoint update. Uncomment tests for …
SteveBronder Apr 18, 2024
b2af1cd
Merge commit '11663a2e79e6dc4286ebf1399573a7048667b1c5' into HEAD
yashikno Apr 18, 2024
b0815c4
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 18, 2024
86a3e83
Merge pull request #3048 from stan-dev/fix/csr-matrix-times-vector
SteveBronder Apr 19, 2024
1f25ef7
Initial updates for winarm64
andrjohns Apr 21, 2024
c9f76db
Fix path error
andrjohns Apr 21, 2024
7a5a009
Update comments
andrjohns Apr 21, 2024
df305d6
Document TBB changes
andrjohns Apr 21, 2024
08d8a22
Merge pull request #3051 from stan-dev/tbb-winarm64
WardBrian Apr 22, 2024
34cf554
use a seperate class for csr_matrix adjoint
SteveBronder Apr 24, 2024
a3a88a5
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 24, 2024
f748825
update docs for new vari for csr_matrix_times_vector
SteveBronder Apr 25, 2024
04124da
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 25, 2024
9f759e1
Merge pull request #3053 from stan-dev/fix/csr-matrix-seperate-vari
SteveBronder Apr 26, 2024
045073f
Don't set build and clean rules for sundials if external libs used
andrjohns Apr 26, 2024
e73651b
Merge pull request #3054 from stan-dev/sundials-targets
WardBrian Apr 26, 2024
cc1cb37
Only apply changes to log inv_Phi
andrjohns Apr 26, 2024
0af021b
Update hessian functors with sparse matrix overload
andrjohns Apr 28, 2024
2e2b85e
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 28, 2024
39ba71f
Update insert
andrjohns Apr 28, 2024
974c10e
Fix downstream failure due to missing value_of
andrjohns Apr 30, 2024
1a28bbc
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot Apr 30, 2024
78c0533
Missed using
andrjohns Apr 30, 2024
9202f1f
Merge pull request #3046 from stan-dev/inv_phi-opt
andrjohns Apr 30, 2024
fd93d21
changed check_positive to check_nonnegative in RNGs for multinomial a…
chvandorp May 3, 2024
4094a19
Update GHA tests to run using RTools44
andrjohns May 4, 2024
d950422
Fix bug in tests
andrjohns May 4, 2024
6beecf2
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot May 4, 2024
1cfdc67
Undo stray test change
andrjohns May 4, 2024
7326216
Squash ARM64 fix commits
andrjohns May 5, 2024
32a2457
Test glibcxx random flag fix
andrjohns May 6, 2024
b2b2ad8
Merge pull request #3059 from stan-dev/arm64-tests
WardBrian May 6, 2024
ee65daa
Merge pull request #3055 from stan-dev/hess-sparse
andrjohns May 6, 2024
07cb7ab
Request C++17 by default, add fallback flag for now
WardBrian May 6, 2024
6ee370a
Merge branch 'develop' into rtools44-gha
andrjohns May 6, 2024
1830097
Merge pull request #3061 from chvandorp/bugfix/issue-3057-multinomial…
WardBrian May 7, 2024
39bf2ae
Revert "Allow Hessian functors to return Hessian as compressed sparse…
SteveBronder May 9, 2024
35d37ce
Merge pull request #3064 from stan-dev/revert-3055-hess-sparse
SteveBronder May 10, 2024
8aca589
use tbb::concurrent_unordered_map instead of std::map so data races d…
SteveBronder May 10, 2024
452ad8e
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot May 10, 2024
b47928d
Merge pull request #3060 from stan-dev/rtools44-gha
WardBrian May 11, 2024
53ff81d
Merge pull request #3066 from stan-dev/fix/profile-data-race
SteveBronder May 11, 2024
c19cdad
updating version numbers for 4.9.0 rc
May 13, 2024
887a2e7
updating version numbers for 4.9.0 rc (#3067)
serban-nicusor-toptal May 13, 2024
fdec5b1
Fix ld error with TBB_LIB on macos
andrjohns May 16, 2024
814d915
Merge pull request #3070 from stan-dev/tbb-lib-macos
andrjohns May 16, 2024
9b71558
update to use logic to check compiler version for c++17 compatability
SteveBronder May 16, 2024
e43440c
update to use logic to check compiler version for c++17 compatability
SteveBronder May 16, 2024
a4bc3cd
fix type where HAS_CXX17 should be false for ifeq failure
SteveBronder May 16, 2024
16337a1
cleanup make definitions for c++17
SteveBronder May 17, 2024
e8de696
Backport SUNDIALS bugfix for hashmap int overflow
andrjohns May 20, 2024
b12cfbd
Merge pull request #3072 from stan-dev/sundials-hashmap-win
SteveBronder May 20, 2024
8e76f01
Merge pull request #3063 from stan-dev/cpp17-smoke-test
SteveBronder May 21, 2024
22c9472
Silence -Wclass-memaccess from TBB
WardBrian May 21, 2024
4a88b9a
Warning is gcc only
WardBrian May 21, 2024
d99f263
Merge pull request #3074 from stan-dev/silence-Wclass-memaccess
andrjohns May 22, 2024
43847e5
Remove problematic calls to std::move in hcubature
WardBrian May 22, 2024
9575d1a
[Jenkins] auto-formatting by clang-format version 10.0.0-4ubuntu1
stan-buildbot May 22, 2024
d1fbb3b
CI Debug: print compiler flags
WardBrian May 22, 2024
ce63b87
Merge pull request #3077 from stan-dev/fix/3075-hcubature-bad-moves
WardBrian May 22, 2024
3689e80
Allow better customization of the LDFLAGS_TBB variable
WardBrian May 23, 2024
4442da3
Merge pull request #3079 from stan-dev/makefile/tbb-dtag-flag
andrjohns May 23, 2024
e1fcbe8
Merge pull request #3078 from stan-dev/ci/debug-print-compiler-flags
WardBrian May 24, 2024
a064d00
Merge branch 'develop' into release/v4.9.0
Jun 3, 2024
8a09048
Add release notes
Jun 3, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Backport SUNDIALS bugfix for hashmap int overflow
  • Loading branch information
andrjohns committed May 20, 2024
commit e8de696a9a655be90e05851f2a54e421191920cb
3 changes: 3 additions & 0 deletions lib/sundials_6.1.1/STAN_CHANGES
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
This file documents changes done for the stan-math project

- Backported bugfix for hashmap int overflow on Windows (https://github.com/LLNL/sundials/pull/421)
7 changes: 4 additions & 3 deletions lib/sundials_6.1.1/src/sundials/sundials_hashmap.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#ifndef _SUNDIALS_HASHMAP_H
#define _SUNDIALS_HASHMAP_H

#include <stdint.h>
#include <string.h>
#include <stdlib.h>

Expand All @@ -30,10 +31,10 @@
This is a 64-bit implementation of the 'a' modification of the
Fowler–Noll–Vo hash (i.e., FNV1-a).
*/
static unsigned long fnv1a_hash(const char* str)
static uint64_t fnv1a_hash(const char* str)
{
const unsigned long prime = 14695981039346656037U; /* prime */
unsigned long hash = 1099511628211U; /* offset basis */
const uint64_t prime = 14695981039346656037U; /* prime */
uint64_t hash = 1099511628211U; /* offset basis */
char c;
while ((c = *str++))
hash = (hash^c) * prime;
Expand Down