Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux gcc tests to travis config. #483

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

seantalts
Copy link
Member

Unclear why we removed it; see this thread for discussion.
http://discourse.mc-stan.org/t/dev-ops/223

Submisison Checklist

  • Declare copyright holder and open-source license: see below

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Dual Space LLC

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Unclear why we removed it; see this thread for discussion.
http://discourse.mc-stan.org/t/dev-ops/223
Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bob-carpenter
Copy link
Contributor

@seantalts --- Can you take a look at what's up with this one? It appears to be dead in travis, though I kicked off the failing tests again.

@seantalts
Copy link
Member Author

Okay, so we think we've seen this issue come to the forefront now that our Windows builds are also using an updated gcc. Bob is working on a fix and we want this to be tested in math (instead of just the upstream Stan windows tests for now), so merging this.

@seantalts seantalts merged commit 52ac66d into develop Apr 24, 2017
@seantalts seantalts deleted the try_adding_gcc_back_for_linux branch April 24, 2017 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants