ifdef out remaining printf statements

[wds15]

Submission Checklist

• Run unit tests: ./runTests.py test/unit
• Run cpplint: make cpplint
• Declare copyright holder and open-source license: see below

Summary:

disables printf functions from CVODES by wrapping them in ifdef blocks controlled by NO_FPRINTF_OUTPUT

Intended Effect:

make CRAN happy which forbids any printf calls in binaries (even if they are not called).

closes #524

How to Verify:

build cvodes and then

cd lib/cvodes_2.9.0
grep -R -F -n -w "printf" .

this should not show any of the binary files pop up.

Side Effects:

Documentation:

Reviewer Suggestions:

@bgoodri

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Sebastian Weber

By submitting this pull request, the copyright holder is requiring to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
• Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[bob-carpenter]

I think you need to move the initial ifndef above the variable declarations to avoid a bunch of unused variable warnings when NO-FPRINTF_OUTPUT is specified. Otherwise, it looks OK.

The warnings won't trigger if we never instantiate these functions, but I think the code will be cleaner above the vars anyway.

[bob-carpenter]

This ifndef should go above the variables or you're going to trigger a bunch of unused variable warnings.

This seems to be a pattern in all of these, but I'm only mentioning it once here.

[wds15]

Thanks Bob. Should be fixed now.