Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Inverse scale' in gamma error output. #530

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

doikov
Copy link
Contributor

@doikov doikov commented Apr 23, 2017

Submission Checklist

  • Run unit tests: ./runTests.py test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary:

gamma_* functions use shape and rate (inverse scale) parametrization for Gamma distribution.
Now the doc and the parameters checkers are consistent with the input parameters.

The issue: #514

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Nikita Doykov

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter
Copy link
Contributor

bob-carpenter commented Apr 24, 2017

@Doykov: Thanks for the fix.

We need a copyright declaration and an agreement by the copyright holder to release the code open source before we can merge.

Copy link
Contributor

@bob-carpenter bob-carpenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great. We just need copyright/licensing sign off (just edit the original pull request) and this is good to go.

@doikov
Copy link
Contributor Author

doikov commented Apr 25, 2017

I've added the copyright.

make cpplint returns:
make: *** [cpplint] Error 1
as before the commit.
I didn't get why, but this pull request is only about comments so I think It's ready to be merged.

@bob-carpenter bob-carpenter merged commit 6f02a99 into develop Apr 26, 2017
@bob-carpenter bob-carpenter deleted the bugfix/issue-514-gamma-parameter-name branch April 26, 2017 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants