Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/0568 fwd core tests #572

Merged
merged 11 commits into from
Jul 7, 2017
Merged

Conversation

bob-carpenter
Copy link
Contributor

Submission Checklist

  • Run unit tests: ./runTests.py test/unit
  • Run cpplint: make cpplint
  • Declare copyright holder and open-source license: see below

Summary:

Finishes testing for core C++ library component of mixed-mode autodiff up to 3rd order.

Required additions of logical operators (!, && and ||).

Tests switched from big enumerations to framework that tests against double results and tests derivatives with finite diffs.

Intended Effect:

Enable us to trust higher-order autodiff for core C++ lib.

How to Verify:

Lots and lots of tests.

Side Effects:

No.

Documentation:

Added doxygen doc for functions that didn't have it and for new functions.

Reviewer Suggestions:

anyone

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

@bob-carpenter
Copy link
Contributor Author

Even with six new function implementations, doc for all the operators, and much more thorough testing, it's still -3000 lines!

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome cleanup!!!

@mitzimorris mitzimorris merged commit 5fcd775 into develop Jul 7, 2017
@mitzimorris mitzimorris deleted the feature/0568-fwd-core-tests branch July 7, 2017 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants