Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py test/unit
make cpplint
Summary:
Finishes testing for core C++ library component of mixed-mode autodiff up to 3rd order.
Required additions of logical operators (
!
,&&
and||
).Tests switched from big enumerations to framework that tests against
double
results and tests derivatives with finite diffs.Intended Effect:
Enable us to trust higher-order autodiff for core C++ lib.
How to Verify:
Lots and lots of tests.
Side Effects:
No.
Documentation:
Added doxygen doc for functions that didn't have it and for new functions.
Reviewer Suggestions:
anyone
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Columbia University
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: