Feature/bounds no inf

[bbbales2]

Submission Checklist

• Run unit tests: ./runTests.py src/test/unit
• Run cpplint: make cpplint
• Declare copyright holder and open-source license: see below

Summary

Fix #2994

Side Effects

Infinite bounds are not okay any more

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company): Columbia University

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

• Code: BSD 3-clause (https://opensource.org/licenses/BSD-3-Clause)
• Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

[bbbales2]

@rok-cesnovar Ack, actually Rok this pull and this pull (Math) will needed synced. There's a test here that is tested expected behavior of the lower/upper bounds in Math, and I'm changing that behavior because it doesn't quite make sense (#2994 and stan-dev/math#2291).

What is the routine for something like this? I could just remove the tests here temporarily and add them back once Math is in (the functions are tested in Math).

[rok-cesnovar]

The routine is the math tests are started pointing to this PR in Jenkins which makes the problematic test pass.

And this PR should point to that Math. The Travis test will fail but we will ignore that.

Are both prs ready? If so I can handle Jenkins.

[bbbales2]

@rok-cesnovar not ready yet -- so I need to:

1. Point this at the proper Math
2. Get this reviewed
3. Get Math reviewed

And then ping you?

[rok-cesnovar]

The pointing happens in jenkins. The Stan PR should not touch the submodule. So just 2 & 3 and then ping me.

[bbbales2]

Okay cool, thanks!

[SteveBronder]

For this could we just delete these infinity tests in one PR, then when the constrains PR is merged to math add the new ones?

[stan-buildbot]

---

Name	Old Result	New Result	Ratio	Performance change( 1 - new / old )
gp_pois_regr/gp_pois_regr.stan	3.42	3.47	0.99	-1.46% slower
low_dim_corr_gauss/low_dim_corr_gauss.stan	0.02	0.02	0.97	-3.49% slower
eight_schools/eight_schools.stan	0.11	0.11	1.0	-0.35% slower
gp_regr/gp_regr.stan	0.15	0.15	1.02	1.65% faster
irt_2pl/irt_2pl.stan	5.32	5.27	1.01	0.96% faster
performance.compilation	90.81	88.38	1.03	2.68% faster
low_dim_gauss_mix_collapse/low_dim_gauss_mix_collapse.stan	8.61	7.8	1.1	9.38% faster
pkpd/one_comp_mm_elim_abs.stan	28.4	28.04	1.01	1.24% faster
sir/sir.stan	134.83	131.43	1.03	2.52% faster
gp_regr/gen_gp_data.stan	0.04	0.05	0.96	-4.65% slower
low_dim_gauss_mix/low_dim_gauss_mix.stan	3.04	3.01	1.01	1.12% faster
pkpd/sim_one_comp_mm_elim_abs.stan	0.39	0.38	1.04	3.71% faster
arK/arK.stan	2.56	2.52	1.02	1.59% faster
arma/arma.stan	0.61	0.73	0.83	-20.51% slower
garch/garch.stan	0.53	0.66	0.81	-23.32% slower
Mean result: 0.987123003819

---

Jenkins Console Log
Blue Ocean
Commit hash: 8d62db8

---

Machine information

ProductName: Mac OS X ProductVersion: 10.11.6 BuildVersion: 15G22010

CPU:
Intel(R) Xeon(R) CPU E5-1680 v2 @ 3.00GHz

G++:
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

Clang:
Apple LLVM version 7.0.2 (clang-700.1.81)
Target: x86_64-apple-darwin15.6.0
Thread model: posix

[rok-cesnovar]

Good