Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collapse all require templates into a require_all #1157

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Collapse all require templates into a require_all #1157

merged 1 commit into from
Apr 8, 2022

Conversation

WardBrian
Copy link
Member

This requires stan-dev/math#2694

Submission Checklist

  • Run unit tests
  • Documentation
    • OR, no user-facing changes were made

Release notes

Improve compile times by accumulating all template requirements into a single require_all_t on user defined functions.

Copyright and Licensing

By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the BSD 3-clause license (https://opensource.org/licenses/BSD-3-Clause)

@WardBrian
Copy link
Member Author

@SteveBronder or @rok-cesnovar mind taking a look at this?

@WardBrian
Copy link
Member Author

I think this also supersedes #1107

@rok-cesnovar
Copy link
Member

I am reviewing now!

SteveBronder
SteveBronder approved these changes Apr 4, 2022
View reviewed changes
Copy link
Contributor

@SteveBronder SteveBronder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good! Just waiting on stan math to propogate up to cmdstan and then we can merge this

@WardBrian WardBrian merged commit 04173c6 into stan-dev:master Apr 8, 2022
@WardBrian WardBrian deleted the requires_all branch April 8, 2022 14:08
@WardBrian WardBrian mentioned this pull request Apr 11, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveBronder SteveBronder SteveBronder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WardBrian @rok-cesnovar @SteveBronder