Fix hash calculation documentation: change 1 to 0 in v1 (deprecated) … #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1304/ . |
1 similar comment
|
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1304/ . |
|
Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1304/ . |
|
@Benjtalkshow Thank you for the contribution! |
raizo07
pushed a commit
to raizo07/starknet-docs
that referenced
this pull request
Jul 9, 2024
LandauRaz
added a commit
that referenced
this pull request
Aug 8, 2024
* doc: compiled class hash * further improvement to the doc * fix: Dir structure changes for SEO (#1261) * Changed /documentation/ to /root/ in antora.yml. * Changed root to ROOT. * Change file names for SEO: * underscores to hyphens * uppercase to lowercase * Change file names for SEO to be match content matter * Added broken links from 3rd party sites * Update messaging-mechanism.adoc to latest on main. * Updated xrefs in messaging-mechanism.adoc. * Updated URL for preview to drop `/documentation/` * fix: Change "cross-chain" to "cross-layer" in L1-L2 Messaging mechanism (#1289) * Change "cross-chain" to "cross-layer" in L1-L2 Messaging mechanism * Apply suggestions from code review * Removed `seo-optimization` branch from playbook. (#1299) * docs: add messaging_reference.adoc (#1094) * create messaging_reference.adoc * add messaging_reference.adoc to nav * add the functions implemented in StarknetMessaging.sol but not part of the IStarknetMessaging.sol * Explain `deployer_address` * Added links between consumeMessageFromL2 function and ConsumedMessageToL2 event. * Added links between consumeMessageFromL2 function and ConsumedMessageToL2 event. * modify event descriptions and add event heading for functions * fix directory structure * Comment out events from internal `processMessages` function * docs: Update Starknet book ToC (#1297) * Update Starknet book ToC: Update outdated information about Starknet book --------- Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> * fix typo adding class hashes in tx v3 invoke computation (#1292) * Update playbook.yml to use main branch for ui-bundle.zip (#1306) * Fix hash calculation documentation: change 1 to 0 in v1 (deprecated) hash calculation (#1304) * docs: Update transactions.adoc with txs v3 fee estimation (#1296) * Update transactions.adoc with txs v3 fee estimation * Update transactions.adoc * Update transactions.adoc * Update transactions.adoc --------- Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> * Update transaction-life-cycle.adoc with finality status of deploy_account and declare transactions (#1295) * Update transaction-life-cycle.adoc with finality status of deploy_account and declare transactions --------- Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> * docs: add validate warnings and refactor the account's functions page (#1302) * add validate warnings and refactor account functions page * fix typo * minor fixes * Update serialization-of-cairo-types.adoc (#1307) * docs: Migrate Provers topic from the Starknet Book (#1270) * Migrating Provers topic from the Starknet Book at https://book.starknet.io/ch03-03-provers.html. * Import sharp.adoc from the Book in order to bring in a commit with multiple contributors. * Edits, and removed sharp.adoc --------- Co-authored-by: Omar U. Espejel <espejelomar@gmail.com> * Update README.adoc * docs: add L1HandlerTransaction table and info on caller address (#1275) * feat: add l1 handler transaction type version * fix: fix typo * fix: fix typo * fix: add a new ref to l1 handler transaction * fix: reword L1HandlerTransaction to L1 handler transaction in normal text * fix: reword for consistent format and better readability * Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/messaging-mechanism.adoc * Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/messaging-mechanism.adoc * fix: remove old file * Update components/Starknet/modules/architecture-and-concepts/pages/network-architecture/transactions.adoc Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> * fix: reword as suggested --------- Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> * Added a link to info on the L1 handler tx type from the tx versions table. (#1312) * Update components/Starknet/modules/architecture-and-concepts/nav.adoc * change file name to use hyphens * implement reviewed changes * Update nav.adoc --------- Co-authored-by: Steve Goodman <39279277+stoobie@users.noreply.github.com> Co-authored-by: xiaolou86 <20718693+xiaolou86@users.noreply.github.com> Co-authored-by: Lauri Peltonen <20242241+microbecode@users.noreply.github.com> Co-authored-by: antiyro <74653697+antiyro@users.noreply.github.com> Co-authored-by: Nnaji Benjamin <60315147+Benjtalkshow@users.noreply.github.com> Co-authored-by: odednaor <odednaor@gmail.com> Co-authored-by: ArielElp <86294909+ArielElp@users.noreply.github.com> Co-authored-by: jumpman <57270771+kkawula@users.noreply.github.com> Co-authored-by: Omar U. Espejel <espejelomar@gmail.com> Co-authored-by: Raz Landau <125185051+LandauRaz@users.noreply.github.com> Co-authored-by: glihm <dev@glihm.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hash calculation documentation for v1 (deprecated) transactions
Description
This PR addresses the issue #1284 where the deprecated
INVOKEv1 transaction hash calculation documentation contains a wrong field value. Specifically, the placeholder value "1" should be "0" to align with the hash computation for the different types of transactions.Changes Made
INVOKEv1 (deprecated) transaction hash calculation documentation:1to0in the hash calculation example.Affected Files
starknet-docs/components/Starknet/modules/architecture_and_concepts/pages/Network_Architecture/transactions.adocVerification
Related Issue
Screenshot
Please review the changes and provide feedback. Thank you .
This change is