Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add preset files of starknet networks #1199

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

yoavGrs
Copy link
Contributor

@yoavGrs yoavGrs commented Sep 20, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@yoavGrs yoavGrs self-assigned this Sep 20, 2023
Copy link
Contributor

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

@yoavGrs yoavGrs added this pull request to the merge queue Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #1199 (124c92e) into main (b758224) will decrease coverage by 0.40%.
Report is 6 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1199      +/-   ##
==========================================
- Coverage   71.83%   71.43%   -0.40%     
==========================================
  Files          75       77       +2     
  Lines        7427     7509      +82     
  Branches     7427     7509      +82     
==========================================
+ Hits         5335     5364      +29     
- Misses       1198     1246      +48     
- Partials      894      899       +5     
Files Changed Coverage Δ
crates/papyrus_config/src/lib.rs 61.90% <ø> (ø)
crates/papyrus_monitoring_gateway/src/lib.rs 63.02% <ø> (-1.63%) ⬇️
crates/papyrus_node/src/bin/dump_config.rs 0.00% <ø> (ø)
crates/papyrus_node/src/version.rs 28.57% <ø> (-38.10%) ⬇️
crates/papyrus_rpc/src/lib.rs 92.85% <ø> (ø)
crates/papyrus_rpc/src/rpc_metrics/mod.rs 69.56% <ø> (-28.40%) ⬇️
crates/papyrus_rpc/src/v0_3_0/transaction.rs 75.33% <ø> (-2.24%) ⬇️
crates/papyrus_rpc/src/v0_4_0/transaction.rs 77.39% <ø> (-2.05%) ⬇️
crates/papyrus_storage/src/lib.rs 44.31% <ø> (ø)
crates/papyrus_sync/src/lib.rs 69.77% <ø> (ø)
... and 2 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit 68ab8e8 Sep 20, 2023
52 checks passed
@yoavGrs yoavGrs deleted the yoav/deployment/preset_files branch September 20, 2023 12:40
@github-actions github-actions bot locked and limited conversation to collaborators Sep 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants