-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dump_decalared_classes fix goerli #1295
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1295 +/- ##
==========================================
- Coverage 72.48% 72.39% -0.09%
==========================================
Files 84 84
Lines 8082 8094 +12
Branches 8082 8094 +12
==========================================
+ Hits 5858 5860 +2
- Misses 1291 1300 +9
- Partials 933 934 +1
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
a82a685
to
7b9fb00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)
crates/dump_declared_classes/src/main.rs
line 78 at r1 (raw file):
start_block, end_block, file_path: file_path.to_string(),
maybe move the to_string() to the variable declaration above (for both file_path and chain_id).
7b9fb00
to
abf69bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @OmriEshhar1)
crates/dump_declared_classes/src/main.rs
line 78 at r1 (raw file):
Previously, OmriEshhar1 wrote…
maybe move the to_string() to the variable declaration above (for both file_path and chain_id).
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is