Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dump_decalared_classes fix goerli #1295

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

Yael-Starkware
Copy link
Contributor

@Yael-Starkware Yael-Starkware commented Oct 22, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@codecov
Copy link

codecov bot commented Oct 22, 2023

Codecov Report

Merging #1295 (abf69bc) into main (f6a3721) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1295      +/-   ##
==========================================
- Coverage   72.48%   72.39%   -0.09%     
==========================================
  Files          84       84              
  Lines        8082     8094      +12     
  Branches     8082     8094      +12     
==========================================
+ Hits         5858     5860       +2     
- Misses       1291     1300       +9     
- Partials      933      934       +1     
Files Coverage Δ
crates/papyrus_storage/src/utils.rs 53.84% <0.00%> (-1.42%) ⬇️
crates/dump_declared_classes/src/main.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Yael-Starkware)


crates/dump_declared_classes/src/main.rs line 78 at r1 (raw file):

        start_block,
        end_block,
        file_path: file_path.to_string(),

maybe move the to_string() to the variable declaration above (for both file_path and chain_id).

Copy link
Contributor Author

@Yael-Starkware Yael-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @OmriEshhar1)


crates/dump_declared_classes/src/main.rs line 78 at r1 (raw file):

Previously, OmriEshhar1 wrote…

maybe move the to_string() to the variable declaration above (for both file_path and chain_id).

Done.

Copy link
Contributor

@OmriEshhar1 OmriEshhar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Oct 23, 2023
Merged via the queue into main with commit 1e5c93c Oct 23, 2023
35 of 36 checks passed
@Yael-Starkware Yael-Starkware deleted the yael/dump_classes_fix_goerli branch October 23, 2023 07:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants