-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): wrapper class for versioned objects #1710
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1710 +/- ##
==========================================
- Coverage 73.35% 73.33% -0.02%
==========================================
Files 120 120
Lines 16560 16589 +29
Branches 16560 16589 +29
==========================================
+ Hits 12147 12166 +19
- Misses 2608 2614 +6
- Partials 1805 1809 +4 ☔ View full report in Codecov by Sentry. |
d5a7531
to
c9b0854
Compare
Can you please draft the usage for version 0 and header? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 149 of 149 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @yair-starkware)
crates/papyrus_storage/src/db/table_types/simple_table.rs
line 80 at r2 (raw file):
return Ok(None); }; Ok(<Self::Value>::deserialize(&mut bytes.as_ref()))
Please explain this change.
Code quote:
Ok(<Self::Value>::deserialize(&mut bytes.as_ref()))
crates/papyrus_storage/src/mmap_file/mod.rs
line 277 at r2 (raw file):
&self, res: &mut impl std::io::Write, ) -> Result<(), crate::db::serialization::StorageSerdeError> {
Not related to this PR, consider reverting and adding a GFI.
Code quote:
crate::db::serialization::
c9b0854
to
7c16727
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 146 of 149 files reviewed, 1 unresolved discussion (waiting on @dan-starkware)
a discussion (no related file):
Previously, dan-starkware wrote…
Can you please draft the usage for version 0 and header?
crates/papyrus_storage/src/db/table_types/simple_table.rs
line 80 at r2 (raw file):
Previously, dan-starkware wrote…
Please explain this change.
reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yair-starkware)
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is