fix(network): remove peer id from network manager

[nagmo-starkware]

Pull Request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build-related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

• Yes
• No

Other information

---

This change is 

[nagmo-starkware]

• fix(network): remove peer id from network manager #1927 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nagmo-starkware and the rest of your teammates on Graphite

[ShahakShama]

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @nagmo-starkware)

---

crates/papyrus_network/src/network_manager/mod.rs line 335 at r1 (raw file):

        let mut query_bytes = vec![];
        query.encode(&mut query_bytes).expect("failed to encode query");
        match self.swarm.send_query(query_bytes, PeerId::random(), protocol) {

Remove peer id as an argument instead of passing a random peer id

---

crates/papyrus_network/src/network_manager/test.rs line 447 at r1 (raw file):

#[tokio::test]
async fn return_fin_to_subscriber_unit_test() {

Why erase this test?

[nagmo-starkware]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ShahakShama)

---

crates/papyrus_network/src/network_manager/mod.rs line 335 at r1 (raw file):

Previously, ShahakShama wrote…

Remove peer id as an argument instead of passing a random peer id

there's atodo for that it's a bit more involved

---

crates/papyrus_network/src/network_manager/test.rs line 447 at r1 (raw file):

Previously, ShahakShama wrote…

Why erase this test?

not relevant any more the funtion being tested is deleted

[ShahakShama]

Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)