Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(network): pm support multiple connection ids #1948

Merged
merged 1 commit into from
May 9, 2024

Conversation

nagmo-starkware
Copy link
Contributor

@nagmo-starkware nagmo-starkware commented May 2, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

@nagmo-starkware
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @nagmo-starkware and the rest of your teammates on Graphite Graphite

ShahakShama
ShahakShama previously approved these changes May 9, 2024
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

@ShahakShama ShahakShama force-pushed the nevo/network/pm_support_multiple_connection_ids branch from 99de19e to dfeabe5 Compare May 9, 2024 08:06
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

@ShahakShama ShahakShama marked this pull request as ready for review May 9, 2024 08:06
@ShahakShama ShahakShama enabled auto-merge May 9, 2024 08:07
Copy link
Contributor

@ShahakShama ShahakShama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nagmo-starkware)

@ShahakShama ShahakShama added this pull request to the merge queue May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 75.03%. Comparing base (ff7e58e) to head (dfeabe5).

Files Patch % Lines
...papyrus_network/src/peer_manager/behaviour_impl.rs 25.00% 6 Missing ⚠️
crates/papyrus_network/src/peer_manager/peer.rs 75.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1948   +/-   ##
=======================================
  Coverage   75.03%   75.03%           
=======================================
  Files         126      126           
  Lines       15955    15956    +1     
  Branches    15955    15956    +1     
=======================================
+ Hits        11972    11973    +1     
+ Misses       2673     2672    -1     
- Partials     1310     1311    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into main with commit 3cdcda4 May 9, 2024
34 checks passed
@ShahakShama ShahakShama deleted the nevo/network/pm_support_multiple_connection_ids branch May 9, 2024 08:17
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants