Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: externalize compiled contract class for mempool #2164

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

Yael-Starkware
Copy link
Contributor

@Yael-Starkware Yael-Starkware commented Jun 27, 2024

This change is Reviewable

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.50%. Comparing base (c4d829c) to head (cfbf7a4).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2164   +/-   ##
=======================================
  Coverage   65.50%   65.50%           
=======================================
  Files         136      136           
  Lines       17951    17951           
  Branches    17951    17951           
=======================================
  Hits        11759    11759           
  Misses       4907     4907           
  Partials     1285     1285           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dan-starkware
dan-starkware previously approved these changes Jun 29, 2024
@Yael-Starkware Yael-Starkware removed the request for review from DvirYo-starkware June 30, 2024 05:50
@Yael-Starkware Yael-Starkware force-pushed the yael/externalize_compiled_contract_class branch from 3a3eb2c to d820a63 Compare June 30, 2024 07:14
Copy link
Collaborator

@dan-starkware dan-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Yael-Starkware)

@Yael-Starkware Yael-Starkware added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit d350df7 Jul 1, 2024
19 checks passed
@Yael-Starkware Yael-Starkware deleted the yael/externalize_compiled_contract_class branch July 1, 2024 06:57
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants