Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dvir/tx hash to block body #891

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Conversation

DvirYo-starkware
Copy link
Contributor

@DvirYo-starkware DvirYo-starkware commented Jul 23, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information


This change is Reviewable

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 14 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware and @DvirYo-starkware)


crates/papyrus_storage/src/body/mod.rs line 102 at r2 (raw file):

    fn get_transaction_hash_by_idx(
        &self,
        tx_hash: &TransactionIndex,

rename

Code quote:

tx_hash

crates/papyrus_storage/src/body/mod.rs line 207 at r2 (raw file):

    fn get_transaction_hash_by_idx(
        &self,
        tx_hash: &TransactionIndex,

rename

Code quote:

tx_hash

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #891 (2ecfa13) into main (de7b990) will decrease coverage by 0.01%.
The diff coverage is 73.07%.

@@            Coverage Diff             @@
##             main     #891      +/-   ##
==========================================
- Coverage   73.77%   73.76%   -0.01%     
==========================================
  Files          53       53              
  Lines        4568     4593      +25     
  Branches     4568     4593      +25     
==========================================
+ Hits         3370     3388      +18     
  Misses        544      544              
- Partials      654      661       +7     
Impacted Files Coverage Δ
crates/papyrus_storage/src/db/mod.rs 80.33% <ø> (ø)
crates/papyrus_storage/src/lib.rs 43.18% <0.00%> (-0.50%) ⬇️
crates/papyrus_storage/src/body/mod.rs 77.01% <76.00%> (-0.21%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yair-starkware yair-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)

@DvirYo-starkware DvirYo-starkware added this pull request to the merge queue Jul 24, 2023
Merged via the queue into main with commit 2cf63e1 Jul 24, 2023
16 checks passed
@DvirYo-starkware DvirYo-starkware deleted the dvir/tx_hash_to_block_body branch July 24, 2023 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants