-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dvir/tx hash to block body #891
Conversation
faa6c08
to
b13cddb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 14 files at r1, 14 of 14 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @dan-starkware and @DvirYo-starkware)
crates/papyrus_storage/src/body/mod.rs
line 102 at r2 (raw file):
fn get_transaction_hash_by_idx( &self, tx_hash: &TransactionIndex,
rename
Code quote:
tx_hash
crates/papyrus_storage/src/body/mod.rs
line 207 at r2 (raw file):
fn get_transaction_hash_by_idx( &self, tx_hash: &TransactionIndex,
rename
Code quote:
tx_hash
Codecov Report
@@ Coverage Diff @@
## main #891 +/- ##
==========================================
- Coverage 73.77% 73.76% -0.01%
==========================================
Files 53 53
Lines 4568 4593 +25
Branches 4568 4593 +25
==========================================
+ Hits 3370 3388 +18
Misses 544 544
- Partials 654 661 +7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware)
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information
This change is