shahak/sn writer client/remove transaction enum

[ShahakShama]

• move writer client into reader client crate
• fix(starknet_client): Use crate instead of super
• refactor(starknet_client)!: remove Transaction and AddTransactionResponse (But keeping the variant structs)

---

This change is 

[codecov]

Codecov Report

Merging #905 (b63d675) into main (0cc8fe1) will decrease coverage by 0.10%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #905      +/-   ##
==========================================
- Coverage   73.81%   73.72%   -0.10%     
==========================================
  Files          53       53              
  Lines        4606     4612       +6     
  Branches     4606     4612       +6     
==========================================
  Hits         3400     3400              
- Misses        545      547       +2     
- Partials      661      665       +4     

Files Changed	Coverage Δ
...yrus_gateway/src/v0_3_0/broadcasted_transaction.rs	0.00% <0.00%> (ø)
...rknet_reader_client/src/writer/objects/response.rs	0.00% <ø> (ø)
...et_reader_client/src/writer/objects/transaction.rs	0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[nagmo-starkware]

Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @ShahakShama, and @yair-starkware)

---

crates/starknet_reader_client/src/writer/objects/transaction.rs line 22 at r1 (raw file):

};

// Each transaction type has a field called `type`. This field needs to be of a type that

why not a part of the docs?

[ShahakShama]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dan-starkware, @nagmo-starkware, and @yair-starkware)

---

crates/starknet_reader_client/src/writer/objects/transaction.rs line 22 at r1 (raw file):

Previously, nagmo-starkware wrote…

why not a part of the docs?

Done.

[nagmo-starkware]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dan-starkware, @DvirYo-starkware, and @yair-starkware)