Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qt6.5 support #3

Closed
prudhomm opened this issue Mar 4, 2023 · 15 comments
Closed

Qt6.5 support #3

prudhomm opened this issue Mar 4, 2023 · 15 comments
Assignees
Labels
enhancement New feature or request

Comments

@prudhomm
Copy link

prudhomm commented Mar 4, 2023

Dear @rabits

Qt6.5 should be out very soon.
Do you think that you will continue support qt6-docker?
Will the installer be working with 6.5?

thank you in advance and thank you for the very helpful environment

@prudhomm
Copy link
Author

prudhomm commented Mar 5, 2023

it seems that 6.5 is indeed supported https://aqtinstall.readthedocs.io/en/latest/CHANGELOG.html
great

@rabits
Copy link
Member

rabits commented Mar 5, 2023

Yeah, let me check & update)

@rabits
Copy link
Member

rabits commented Mar 5, 2023

Oh, it's a bit early for the release (planned to 30.03.2023 https://wiki.qt.io/Qt_6.5_Release ) - but when it will be out - for sure)

@rabits rabits self-assigned this Mar 5, 2023
@rabits rabits added the enhancement New feature or request label Mar 5, 2023
@rabits
Copy link
Member

rabits commented Mar 5, 2023

I don't see any weird changes in the changelog, so most probably it will be an easy update.

@prudhomm
Copy link
Author

prudhomm commented Apr 5, 2023

@rabits
Copy link
Member

rabits commented Apr 6, 2023

Yeah, ytd started to build the new images and found 1 issue:

  • in 6.5-macos-aqt the package doesn't want to unpack for some reason:
    + aqt install-src -O /opt/Qt linux 6.5.0 --archives qtbase
    INFO    : aqtinstall(aqt) v3.1.4 on Python 3.8.10 [CPython GCC 9.4.0]
    INFO    : Downloading qtbase...
    INFO    : Redirected: qt.mirror.constant.com
    WARNING : Caught Bad7zFile, terminating installer workers
    ERROR   : not a 7z file
    Traceback (most recent call last):
      File "/usr/local/lib/python3.8/dist-packages/aqt/installer.py", line 180, in run
        args.func(args)
      File "/usr/local/lib/python3.8/dist-packages/aqt/installer.py", line 514, in run_install_src
        self._run_src_doc_examples("src", args)
      File "/usr/local/lib/python3.8/dist-packages/aqt/installer.py", line 501, in _run_src_doc_examples
        run_installer(srcdocexamples_archives.get_packages(), base_dir, sevenzip, keep, _archive_dest)
      File "/usr/local/lib/python3.8/dist-packages/aqt/installer.py", line 1171, in run_installer
        raise e from e
      File "/usr/local/lib/python3.8/dist-packages/aqt/installer.py", line 1130, in run_installer
        pool.starmap(installer, tasks)
      File "/usr/lib/python3.8/multiprocessing/pool.py", line 372, in starmap
        return self._map_async(func, iterable, starmapstar, chunksize).get()
      File "/usr/lib/python3.8/multiprocessing/pool.py", line 771, in get
        raise self._value
    py7zr.exceptions.Bad7zFile: not a 7z file
    

Seems related to miurahr/aqtinstall#662 - so will try with master...

@rabits
Copy link
Member

rabits commented Apr 6, 2023

Yeah, with master the installer works, so will need to wait for the release version of aqt to properly build the macos image. But the rest of the images will upload after the testing.

@rabits
Copy link
Member

rabits commented Apr 6, 2023

Ok, most of the tests passed except for mingw, so starting the upload of everything except for mingw and macos.

rabits added a commit that referenced this issue Apr 6, 2023
rabits added a commit that referenced this issue Apr 6, 2023
@rabits
Copy link
Member

rabits commented Apr 6, 2023

The images of android, gcc and wasm are uploaded.

The issue with mingw image during tests:

...
windeployqt --qmldir ./project --dir build/deploy --libdir build/deploy/libs --plugindir build/deploy/plugins build/appqt_widgets.exe
...
Creating build\deploy\translations...
Creating qt_ar.qm...
Cannot open .: Access denied.

Seems related to this line: https://code.qt.io/cgit/qt/qtbase.git/tree/src/tools/windeployqt/utils.cpp?h=6.5#n774 , but still mysterious why this is happening... Will debug it tomorrow.

@rabits
Copy link
Member

rabits commented Apr 8, 2023

A bit of development - so started the windeployqt with --verbose 2 and it showed that it starts lconvert like:

lconvert -o Z:\home\user\build\deploy\translations\qt_ar.qm . .. assistant_ar.qm [etc...]

So tried to run it separately with wine and seems the output of Cannot open .: Access denied. is coming out of lconvert tool. And seems it doesn't like the ". .." part which is added as a part of arguments here: https://code.qt.io/cgit/qt/qtbase.git/tree/src/tools/windeployqt/main.cpp?h=6.5#n1004.

@rabits
Copy link
Member

rabits commented Apr 9, 2023

With --no-translations it's passing (but a weak workaround, because we need translations...).
And I found another one who struggles from this issue: https://forum.qt.io/topic/144238/windeployqt-qt-6-5-failed-translation-not-found

@prudhomm
Copy link
Author

@rabits one of the new features in Qt6.5 is multithread support in wasm, we will check if it is enabled and report.

@rabits
Copy link
Member

rabits commented Apr 12, 2023

Yeah, I saw it during preparation of wasm image - and since it's needed some additional things to be used properly, I stay with single-threaded one for now by default to keep backward-compatibility. But for sure - if it's needed for the particular pipeline it's not that hard to prepare a separated image based on single-threaded one.

@rabits
Copy link
Member

rabits commented Apr 19, 2023

Seems v3.1.5 was available since end of march and I did not noticed that) So mac image now can be built and soon will be available)

@rabits
Copy link
Member

rabits commented Jun 4, 2023

Oh that was a busy months, but I checked today mingw with 6.5.1 and it passed the tests! So just pushed the mingw for qt 6.5 and it could be used as usual. 6.5 is done now.

@rabits rabits closed this as completed Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants